Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve OSC 9001; CmdNotFound suggestions #17378

Closed
carlos-zamora opened this issue Jun 5, 2024 · 0 comments · Fixed by #17614
Closed

Improve OSC 9001; CmdNotFound suggestions #17378

carlos-zamora opened this issue Jun 5, 2024 · 0 comments · Fixed by #17614
Labels
Area-VT Virtual Terminal sequence support In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@carlos-zamora
Copy link
Member

In #16848, we're just taking the missingCmd from the VT sequence and stuffing it into a winget install <missingCmd>. That's nice, but we can do better! Let's actually use winget to search for some packages and stuff those suggestions into the suggestions UI.

Internally tracking request for winget here: https://microsoft.visualstudio.com/OS/_workitems/edit/50066117
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 5, 2024
@carlos-zamora carlos-zamora mentioned this issue Jun 5, 2024
Merged
@carlos-zamora carlos-zamora added Area-VT Virtual Terminal sequence support Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2024
@carlos-zamora carlos-zamora added the Issue-Task It's a feature request, but it doesn't really need a major design. label Jun 12, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.22 milestone Jun 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Jun 29, 2024
@carlos-zamora @DHowett
Add Quick Fix UI and support for custom CommandNotFound OSC (#16848)
6589957 
### `OSC 9001; CmdNotFound; <missingCmd>`
Adds support for custom OSC "command not found" sequence `OSC 9001;
CmdNotFound; <missingCmd>`. Upon receiving the "CmdNotFound" variant
with the missing command payload, we send the missing command up to the
Quick Fix menu and add it in as `winget install <missingCmd>`.

### Quick Fix UI
The Quick Fix UI is a new UI surface that lives in the gutter (left
padding) of your terminal. The button appears if quick fixes are
available. When clicked, a list of suggestions appears in a flyout. If
there is not enough space in the gutter, the button will be presented in
a collapsed version that expands to a normal size upon hovering over it.

The Quick Fix UI was implemented similar to the context menu. The UI
itself lives in TermControl, but it can be populated by other layers
(i.e. TermApp layer).

Quick Fix suggestions are also automatically loaded into the Suggestions
UI.

If a quick fix is available and a screen reader is attached, we dispatch
an announcement that quick fixes are available to notify the user that
that's the case.

Spec: #17005
#16599

### Follow-ups
- #17377: Add a key binding for quick fix
- #17378: Use winget to search for packages using `missingCmd`

---------

Co-authored-by: Dustin L. Howett <duhowett@microsoft.com>
Co-authored-by: Dustin L. Howett <dustin@howett.net>
@carlos-zamora carlos-zamora mentioned this issue Jul 25, 2024
Merged
2 tasks
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-VT Virtual Terminal sequence support In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging a pull request may close this issue.

Use WinGet API to improve Quick Fix results microsoft/terminal
1 participant
@carlos-zamora