Double clicking on the drag bar to maximize does not update the maximize button icon

[ocalvo]

Double clicking on the drag bar to maximize does not update the maximize button icon, the icon remains the same, by contrast, if you click the maximize button the icon does update.

Environment

Windows 10 19H1
Windows Terminal version (if applicable): master

Any other software?

Steps to reproduce

1. Start Windows Terminal in normal state
2. Double click the drag bar to maximize the window.

Expected behavior

The maximize button icon is updated

Actual behavior

The maximize button icon does not update.

We are not listening from window state change events from the top level window into the mixmaxclose user control.

[gopalrander]

Debugged and noticed that MinMaxCloseControl::DragBar_DoubleTapped() method is not hit when I double clicked the Drag bar. [But the window maximizes; strange?

[DHowett-MSFT]

@gopalrander the drag bar is actually cut out of the window using a region. It's a complicated story about why exactly we need to do this.

[shanselman]

Came here to make this bug. ;) Hitting it daily now. Can't we grab the event and delegate it over?

[warmachinesocial]

Hi Sir/Madam, I would like to ask you that do you also get an identifier error for both byte and HWND in TitlebarControl.h and TitlebarControl.cpp?? The whole section has lots of error. I just wanna confirm that are you also getting the same error?

Also when i debugged i noticed that DragBar_DoubledTapped method the event isn't detected where other detection of clicking the max,min or close the event is detected.

[filip-hejsek]

Maximizing the window by dragging it to the top of the screen has the same problem

[zadjii-msft]

If anyone's interested in fixing this, I think I broke this in #2438.

The trick is that I think we're now treating the titlebar area as HTCAPTION in NonClientIslandWindow, so the mouse presses aren't falling through to the underlying Xaml Island window (the one that draws the TitlebarControl).

We should be able to handle the double-click directly in NonClientIslandWindow directly. I'm a bit curious of why it regressed, but as long as a fix doesn't regress #2028, I'm happy.

[DHowett-MSFT]

Nah, it never was hitting the island here. Double click on a Win32 titlebar always did a maximize by default :)

[ghost]

🎉This issue was addressed in #3025, which has now been successfully released as Windows Terminal Preview v0.5.2762.0.:tada:

Handy links:

• Release Notes
• Store Download