Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Windows Terminal]: Name of the current tab is not visible in high contrast desert theme. #17913

Closed
SaurabhNew opened this issue Sep 12, 2024 · 0 comments · Fixed by #18109
Closed

[Windows Terminal]: Name of the current tab is not visible in high contrast desert theme. #17913

SaurabhNew opened this issue Sep 12, 2024 · 0 comments · Fixed by #18109
Assignees
@carlos-zamora
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.23

Comments

@SaurabhNew
Copy link

Windows Terminal version

1.22.2362.0

Windows build number

27695.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview

Steps to reproduce

Pre-requisite:
Settings>Accessibility>Contrast themes>Desert theme>Reopen the application.

Repro steps:

  1. Open the 'windows terminal' application.
  2. Follow the above-mentioned pre-requisite step.
  3. Now open any application like 'Windows Terminal'.
  4. Observe the issue.

User experience:
Users relying on high contrast themes, such as those with visual impairments, may struggle to identify the current active tab, hindering their ability to navigate efficiently in the terminal. Proper contrast is crucial for accessibility and usability in high contrast modes.

MAS Reference Link:
MAS 4.3.1 – No Disruption of Accessibility Features.docx (sharepoint.com)

Attachment:
MAS4.3.1 - Name of the current tab is not visible in high contrast desert theme.zip

Expected Behavior

The name of the current active tab should be clearly visible in high contrast themes, such as the Desert theme. Proper color contrast should be maintained to ensure the active tab’s name stands out from the background, ensuring easy identification.

Actual Behavior

The name of the current active tab is not visible or is poorly visible when using the High Contrast Desert theme. The tab name blends with the background, making it hard to distinguish which tab is active.
@SaurabhNew SaurabhNew added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 12, 2024
@Priyanka-Chauhan123 Priyanka-Chauhan123 added A11yWCAG Accessibility tracking HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Sep 12, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Sep 12, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 12, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Sep 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 12, 2024
@carlos-zamora carlos-zamora added Area-Accessibility Issues related to accessibility and removed Needs-Tag-Fix Doesn't match tag requirements labels Sep 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Tag-Fix Doesn't match tag requirements labels Sep 12, 2024
@carlos-zamora carlos-zamora mentioned this issue Oct 25, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 25, 2024
@carlos-zamora carlos-zamora self-assigned this Oct 25, 2024
DHowett pushed a commit that referenced this issue Nov 4, 2024
@carlos-zamora
Fix tab contrast colors when in high contrast (#18109)
72df7ac 
Originally, the XAML resources were being applied on the TabView's
ResourceDictionary directly. However, high contrast mode has a few weird
scenarios as it basically reduces the color palette to just a few colors
to ensure high contrast. This PR now stores the resources onto the
ThemeDictionaries so that we have more control over the colors used.

## References and Relevant Issues
Closes #17913
Closes #13067

## Validation Steps Performed
Compared the following scenarios to WinUI 2 gallery's TabView when in
High Contrast mode:
✅ (Un)selected tab
✅ hover over x of (un)selected tab
✅ hover over unselected tab
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.23
Development

Successfully merging a pull request may close this issue.

Fix tab contrast colors when in high contrast microsoft/terminal
3 participants
@carlos-zamora @Priyanka-Chauhan123 @SaurabhNew