Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Terminal - Command Palette]: 'Shortcut keys' in 'Command Palette' are not visible in high contrast themes for focused or hovered rows. #17914

Closed
SaurabhNew opened this issue Sep 12, 2024 · 0 comments · Fixed by #18132
Labels
A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@SaurabhNew
Copy link

Windows Terminal version

1.22.2362.0

Windows build number

27695.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview

Steps to reproduce

Pre-requisite:
Settings>Accessibility>Contrast themes>Aquatic/Desert theme>Reopen the application.

Repro steps:

  1. Open the 'windows terminal' application.
  2. Follow the above-mentioned pre-requisite step.
  3. Now open any application like 'Windows Terminal'.
  4. Open command Palette by pressing 'Ctrl + Shift + P' keys.
  5. 'Command Palette' will open.
  6. Now navigate to any row by up/down arrow keys or hover with mouse.
  7. Observe the issue.

User experience:
Users relying on high contrast themes, especially those with visual impairments, may find it challenging to see the shortcut keys in the Command Palette. This issue impacts navigation efficiency, as users cannot easily identify or use the shortcuts for commands.

MAS Reference Link:
MAS 4.3.1 – No Disruption of Accessibility Features.docx (sharepoint.com)

Attachment:
Shortcut keys is not visible in high contrast themes.zip

Expected Behavior

The shortcut keys for commands in the Command Palette should be clearly visible in high contrast themes when rows are focused or hovered. Proper contrast between the text and background should ensure that users can easily see the shortcut keys.

Actual Behavior

The shortcut keys associated with the commands in the Command Palette are not visible or are poorly visible when focused or hovered in high contrast themes. The lack of proper contrast makes it difficult to see the shortcut keys, impairing navigation.

@SaurabhNew SaurabhNew added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 12, 2024
@Priyanka-Chauhan123 Priyanka-Chauhan123 added HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev3 Accessibility tracking Area-Accessibility Issues related to accessibility labels Sep 12, 2024
@carlos-zamora carlos-zamora added the Product-Terminal The new Windows Terminal. label Sep 12, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Oct 2, 2024
@carlos-zamora carlos-zamora added this to the Backlog milestone Oct 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev3 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants