Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot change to new Nerd Font. Choosing new Nerd font does not save. #18016

Closed
ariukkonen opened this issue Oct 9, 2024 · 3 comments
Closed
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting

Comments

@ariukkonen
Copy link

Windows Terminal version

: 1.21.2701.0

Windows build number

10.0.26100.0

Other Software

oh-my-posh 23.17.0
Avast Premium Security
settings.json

Steps to reproduce

Install IosevkaTerm Nerd Font. Install other Nerd Font like Hack.

Open settings, try to choose Hack Nerd Font and click save. Font change is not saved.

I can change it manually for a profile by editing the settings.json file however and if I choose an non-nerd font and click save, the change will save through the UI.

Expected Behavior

Install IosevkaTerm Nerd Font. Install other Nerd Font like Hack.

Open settings, try to choose Hack Nerd Font and click save. Font change is not saved. Preview does not change when selecting nother nerd font, only changes when selecting a non-nerd font.

I can change it manually for a profile by editing the settings.json file however and if I choose an

Actual Behavior

Selecting another nerd font changes the preview and clicking save changes the saved font for the profile.

@ariukkonen ariukkonen added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 9, 2024
@ariukkonen
Copy link
Author

This was working with previous builds of terminal/windows 11.

@Constrat
Copy link

Constrat commented Oct 9, 2024

It actually looks like you can't change font at all. Not only limited to Nerd Fonts.
Video describing the issue: https://github.com/user-attachments/assets/96848b70-a170-4f89-ae35-8728ebf362ce

EDIT: Manually typing a correct font name and saving will crash the terminal. (Without actually saving the new font)

EDIT2:
Workaround found:

  1. Manually type the entire font name
    a. Do not enter, do not save
  2. Click outside the text label
  3. The preview will get updated
  4. Then you can save

@lhecker
Copy link
Member

lhecker commented Oct 9, 2024

This is a known issue, first reported here: #17987
Because of that we've rolled back the offending change: #17989
Currently I'm redoing the change without the bugs: #18010

Unfortunately, it'll take a little longer for the fix to be released. (@DHowett?)
I'll be closing this issue in the meantime, as it's just pending release. Thank you for the report though!

@lhecker lhecker closed this as completed Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants