Color Picker Lightness Bar/Selector Inoperative

[McCovican]

Windows Terminal version

1.23.12811.0 && 1.24.2812.0

Windows build number

10.0.19045.6575

Other Software

No response

Steps to reproduce

• Open the settings menu of Windows Terminal (stable or preview);
• Go to any option that allows you to customize the colour;
• Click "More Colors";
• A colour-picker menu opens up;
• The large, main square lets you select hue & saturation – this works fine;
• The thin vertical bar on the right is to select the colour lightness value;
• Click on it;

Expected Behavior

You are meant to be able to click a linear y-axis location on this bar, which changes the lightness value of the selected colour.
The bar should also visibly display a gradient of all the lightness values possible for the current hue/saturation selected in the main 2D square box to the left.

Actual Behavior

Clicking on the lightness bar does nothing. Zero feedback whatsoever;
The bar also does not display a lightness gradient – instead, it shows only the actual colour selected. This colour can be influenced by what is selected in the X/Y hue/lightness box, but the lightness value seems to be based solely on the original colour of the property that you're currently modifying. (You can see that it very doesn't match the shade of blue selected in the box)

NB: Ultimately, the colour can be fully configured by setting the hex value manually in the config, but man, that's a right faff.

PS: I actually would've expected the hue to be the thin bar, with lightness/saturation in the larger box. But if the X/Y box is to be hue/saturation, I would then expect the lightness value on the right to dynamically impact the colours shown in the main X/Y box. Ultimately not critical, but if the main box doesn't dynamically update, you'd need to add a new UI element somewhere that accurately represents the currently-selected colour.

[McCovican]

Update: So, this seems to only happen when altering colours that are in a profile. I just found the whole custom colour schemes thing and...

Seems my assumption about the right-side bar being for lightness was in error. Altering colours in a profile (eg: caret colour) is just missing the entire lower-half of the colour-picker box.

[carlos-zamora]

Thanks for filing! Yeah, so the profiles use a custom control I created called the NullableColorPicker. This reuses the color picker in WinUI, but it handles the conversion between the color type Terminal uses and the one WinUI uses. The color picker for color schemes just uses the built-in WinUI one.

There's several customizations that can be applied to the WinUI one (see below). Looks like we should enable a few more of them like "IsMoreButtonVisible" and "IsColorSliderVisible", at least.