Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default tab title too long #2327

Closed
nurbles opened this issue Aug 7, 2019 · 5 comments
Closed

Default tab title too long #2327

nurbles opened this issue Aug 7, 2019 · 5 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@nurbles
Copy link

nurbles commented Aug 7, 2019

The default title for my powershell tabs is so long that (a) it is cut off and (b) the 'X' to close the tab is not displayed, for example:

wt-title

Environment

Windows build number: Microsoft Windows [Version 10.0.18362.239]
Windows Terminal version (if applicable):  0.3.2171.0

Any other software? no

I did edit the settings to make two changes: The point size for all fonts is now 12 instead of 10 and CMD is the default instead of powershell.

Steps to reproduce

Open a powershell tab in Windows Terminal

Expected behavior

At a minimum, I would expect the tab close control to remain visible or at least a click where the control belongs should close the tab.

Actual behavior

The long path appears to overwrite the close tab control and prevent any clicks from reaching the close tab control.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 7, 2019
@carlos-zamora carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Aug 7, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 7, 2019
@carlos-zamora carlos-zamora added this to the Terminal 1908.1 milestone Aug 7, 2019
@mdtauk
Copy link

mdtauk commented Aug 7, 2019

The TabView control template for the tab items, should ensure the close button gets priority as the control scales down.

@DHowett-MSFT
Copy link
Contributor

@mdtauk that is an excellent thing to file over on microsoft/microsoft-ui-xaml./

@DHowett-MSFT
Copy link
Contributor

In the mean time, override the title with tabTitle or change your shell configuration to set a better title.

@DHowett-MSFT
Copy link
Contributor

#608

@DHowett-MSFT DHowett-MSFT added the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Aug 8, 2019
@nurbles
Copy link
Author

nurbles commented Aug 8, 2019

I don't really see the duplication as I was reporting that the close tab control was being overwritten by a long title, while #608 seems to be about configuring custom titles. However, I can understand blaming something else, I do that all the time myself. :-)

FWIW, If I add and remove more tabs, the tab with an over-long title will get 'fixed' to show the whole title and the close control. I have been able to get a new tab to obscure the close control with much shorter tab titles, too, by adding tabs of different types -- it rarely takes more than one of two attempts, no matter which shell type I choose. Oh well. I tried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

5 participants