Hot take: we set the tab title for cmd and powershell by default #2348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this PR to start a discussion about this. If we reach consensus against it, I'm happy to close it. I'm also liking Plan B the more I think on it.
Summary of the Pull Request
We don't set it for WSL, Azure, or Powershell core
Plan B: Add an
"initialTabTitle"
setting. With that set, we'll ignore the first title conpty sets for us. If conpty sets another title, we'll blow the initial title away and continue using the title from VT. This would be more similar to how cmd and powershell use the title from a shortcut currently.References
literally every issue that mentions the length of the tab title, but #2327 was the one that broke the camel's back.
PR Checklist