Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot take: we set the tab title for cmd and powershell by default #2348

Closed
wants to merge 1 commit into from

Conversation

zadjii-msft
Copy link
Member

@zadjii-msft zadjii-msft commented Aug 8, 2019

I'm submitting this PR to start a discussion about this. If we reach consensus against it, I'm happy to close it. I'm also liking Plan B the more I think on it.

Summary of the Pull Request

We don't set it for WSL, Azure, or Powershell core

Plan B: Add an "initialTabTitle" setting. With that set, we'll ignore the first title conpty sets for us. If conpty sets another title, we'll blow the initial title away and continue using the title from VT. This would be more similar to how cmd and powershell use the title from a shortcut currently.

image

References

literally every issue that mentions the length of the tab title, but #2327 was the one that broke the camel's back.

PR Checklist

  • Closes #the-endless-stream-of-complaints-about-tab-titles
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated - Probably does
  • I have not discussed this with core contributors already.

  We don't set it for WSL, Azure, or powershell core
  Fixes #the-endless-stream-of-complaints-about-tab-titles

  Plan B: Add an "initialTabTitle" setting. With that set, we'll ignore the
  _first_ title conpty sets for us. If conpty sets another title, we'll blow the
  initial title away and continue using the title from VT. This would be more
  similar to how cmd and powershell use the title from a shortcut currently.
@mcpiroman
Copy link
Contributor

Maybe instead of initialTabTitle being string make overridableTabTitle boolean, that when set true would make the existing tabTitle behave as described in plan B. And true'd be actually the reasonable default.

@zadjii-msft
Copy link
Member Author

Closed in favor of #2373

@zadjii-msft zadjii-msft closed this Aug 9, 2019
@zadjii-msft zadjii-msft deleted the dev/migrie/b/hot-take branch August 23, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants