Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redraw issue #2352

Closed
SeanTAllen opened this issue Aug 8, 2019 · 11 comments
Closed

Redraw issue #2352

SeanTAllen opened this issue Aug 8, 2019 · 11 comments
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@SeanTAllen
Copy link

SeanTAllen commented Aug 8, 2019 •
edited
Loading

I use fish shell that will display possible autocompletions. In terminal, it doesn't always draw the screen correctly. Here is a screenshot after completion where the last couple ghost characters were left over from the suggested completion. Note, this doesn't always happen. Normally everything is redrawn correctly.
Annotation 2019-08-08 120632

Currently using 0.3.2171.0
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 8, 2019
@zadjii-msft
Copy link
Member

I'd bet money that this is due to us incorrectly guessing the widths of the powerline chars. Looks like they're all being treated as double wide, but I'd imagine they're actually only 1 wide in the buffer.

Could you repro that scenario with the same font set in WSL via conhost.exe (not the Windows Terminal), and paste what it looks like?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 8, 2019
@SeanTAllen
Copy link
Author

SeanTAllen commented Aug 8, 2019 •
edited
Loading

I can not reproduce via conhost.exe nor via the terminal in VSCode. It's purely a Windows Terminal issue.

However, here is a screenshot of what it looks like there (sans issue that doesn't happen there)...

Annotation 2019-08-08 130655

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Aug 8, 2019
@SeanTAllen
Copy link
Author

@zadjii-msft playing with this a bit more in windows terminal, it only appears to happen when the powerline has "git status" icons in it. The font that is used for that, doesn't display those symbols in conhost.

@zadjii-msft
Copy link
Member

Could I get a screenshot with the up and down arrows in conhost? they look like maybe the one we're guessing is 2 wide instead of 1 wide:

These guys:
image

@SeanTAllen
Copy link
Author

Annotation 2019-08-08 131124

@SeanTAllen
Copy link
Author

And here they are in VSCode...

Annotation 2019-08-08 131204

@zadjii-msft
Copy link
Member

Yea that'll do it.

This is probably some combination of issues, #2066 might be the one that ends up fixing it.

@miniksa might also have thoughts on the character being rendered as 2 wide

@zadjii-msft zadjii-msft added Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. labels Aug 8, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 8, 2019
@SeanTAllen
Copy link
Author

@zadjii-msft Let me know if you need anything else from me.

@Dijir
Copy link

Dijir commented Aug 13, 2019

On mine it is not rendering poweline characters correctly.

VSCode:

Windows Terminal:

@ksawerykarwacki
Copy link

ksawerykarwacki commented Aug 14, 2019 •
edited
Loading

@zadjii-msft I have some rare case. Characters have some strange random gaps (they are not always on the same spot) but it is like pixel or two wide not whole character.

{81FF00FF-FB28-4E40-98ED-C4E62F55346B}

@DHowett-MSFT
Copy link
Contributor

This is almost certainly #633 #635, and will be helped by #2066.

@miniksa miniksa added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Attention The core contributors need to come back around and look at this ASAP. labels Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Fonts Related to the font Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Conpty For console issues specifically related to conpty Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@SeanTAllen @Dijir @ksawerykarwacki @DHowett-MSFT @miniksa @zadjii-msft