-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OhMyPosh themes with arrows render gaps before arrow character #633
Comments
Seems like a thing @miniksa might know about |
I don't strictly know why this is, but it's probably a renderer thing so I'll self-assign for now. |
Hi, Also tried with different patched nerd fonts like I'm using the latest master as of right now, with HEAD at 900d0c3 As you can see first lettter of the command (like settings of the ubuntu terminal as below: {
"acrylicOpacity" : 0.5,
"closeOnExit" : true,
"colorScheme" : "Campbell",
"commandline" : "wsl.exe -d Ubuntu",
"cursorColor" : "#FFFFFF",
"cursorShape" : "bar",
"fontFace" : "UbuntuMono NF",
"fontSize" : 10,
"guid" : "{2c4de342-38b7-51cf-b940-2309a097f518}",
"historySize" : 9001,
"icon" : "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png",
"name" : "Ubuntu",
"padding" : "0, 0, 0, 0",
"startingDirectory" : "%USERPROFILE%",
"snapOnInput" : true,
"useAcrylic" : false
} Update: {
"acrylicOpacity" : 0.5,
"closeOnExit" : true,
"colorScheme" : "Campbell",
"commandline" : "wsl.exe -d Ubuntu",
"cursorColor" : "#FFFFFF",
"cursorShape" : "bar",
"fontFace" : "Roboto Mono for Powerline",
"fontSize" : 10,
"guid" : "{2c4de342-38b7-51cf-b940-2309a097f518}",
"historySize" : 9001,
"icon" : "ms-appx:///ProfileIcons/{9acb9455-ca41-5af7-950f-6bca1bc9722f}.png",
"name" : "Ubuntu",
"padding" : "0, 0, 0, 0",
"snapOnInput" : true,
"useAcrylic" : false
} |
Same issue using zsh/oh-my-zsh with powerlevel9k theme I'm using "Sauce Code Powerline" font (patched from nerd-fonts).
|
Copying my explanation from #635.
|
Additionally, this will be forced into submission by #2066. |
In case this isn't documented anywhere else, I'd like to point out that I am also experiencing the glyph width problem when using Terminal 0.5, Posh-Git, and the new Cascadia Code font. The problem occurs when I'm in a folder that is a git repo and has a branch synchronization glyph. When I type the third character of a command, the entire line jumps back one space. |
Me and my colleagues had a bunch of issues with this but it worked for one of us. We're using my LovelyPowershell modules which installs the latest Hack NF fonts from the nerd-fonts master. Turns out those of us that had issues had older versions of the font. The latest on nerd-fonts master makes this issue go away. We're using the Complete Mono Windows Compatible versions. 🎉🎉🎉 Edit: If you try the fonts from the master branch then make sure that the old ones are actually uninstalled. |
Isn't this fixed by the latest release? The arrows seem to work fine for me now |
I am also seeing this as fixed in yesterday's Github release. |
I was able to get the powerline fonts and symbols working by using the settings from #633 (comment) above. However, the colors do not match what I expect them to. I also have the wsltty installed which outputs the correct colors. Has anyone been able to get windows terminal to output the right colors? Or know which setting I should change? |
Confirmed with @DHowett-MSFT that this should be resolved in the upcoming release thanks to #2066. Resolving. |
I have the same problem, it was working fine yesterday and I changed nothing. Opening the terminal for the first time looks like that, and after that, it just works normally. Does anyone know a solution? I tried all suggested fixes above and yet none worked Edit: Found out it is a windows terminal problem, a temporary workaround worked: JanDeDobbeleer/oh-my-posh#172 (comment) |
@MuktadirHassan We're actually tracking that particular issue over in #8341 |
Your Windows build number: (Type
ver
at a Windows Command Prompt)Windows 10 18362.30 (Enterprise)
oh-my-posh 2.0.263 -
agnoster
themeposh-git 0.7.3
Screenshots taken using Nerd Fonts
Inconsolata NF
, also tried usingFuraCode NF
with same results.I am using a build from master as of ~11am PDT today.
What you're doing and what's happening: (Copy & paste specific commands and their output, or include screen shots)
Windows Terminal
Fluent Terminal (expected result)
What's wrong / what should be happening instead:
Arrow characters on powerline should be getting rendered a few pixels to the left, so colour gaps aren't visible (see Fluent Terminal screenshot). Screenshots taken using agnoster theme, but the same happens on other themes utilising those arrows - Paradox and Fish. No issues noticed on themes that don't render this arrow character.
https://github.com/JanDeDobbeleer/oh-my-posh#themes
Edit: removed ohmyposh disabled screenshot, as that doesn't relate to this issue but to the other one I just opened.
The text was updated successfully, but these errors were encountered: