Investigate apparent WinPTY issue with RS5/19H1 builds

[miniksa]

See microsoft/vscode#57803

[miniksa]

Tracked internally assigned to me as MSFT:19205200

[miniksa]

Good news! I found the commit ID that changed the behavior. Yay bisect! Still digging.

[Tyriar]

@miniksa did you end up finding a fix?

[miniksa]

I found it was @zadjii-msft's fault and I passed the buck to him. >__>

But he has a fix in PR right now. It's on my queue to read this morning.

[warpdesign]

Will the fix make it to October 2018 update or do we have to wait for the next big update in 6 months or so?

[zadjii-msft]

@warpdesign The fix won't be in the October 2018 release. It'll be in Insiders builds pretty soon, but if you're afraid of Insiders, then you'll need to wait for the spring release.

[warpdesign]

@zadjii-msft ok, thanks for the info. I'm not afraid if insiders but my Surface Book already had lots of problems with the stable releases, don't want to put it to stress :)

I hope the @code team will find a workaround before the fix is released as stable then (see microsoft/vscode#57803).

[Tyriar]

@warpdesign well the workaround is to upgrade to conpty which is blocked on Electron 3 which we're aiming for January currently microsoft/vscode#52629

[Stanzilla]

@zadjii-msft what are the chances of shipping important fixes like this in a cumulative update?

[zadjii-msft]

@Stanzilla Effectively none. There's very little chance that we ship any console bugfixes downlevel.

[doxxx]

Effectively none. There's very little chance that we ship any console bugfixes downlevel.

This really needs to change.

[syntag]

It's still an issue for me. @zadjii-msft mentioned that it will be available to us 3-4 weeks from Oct 15, but it's been long past due microsoft/vscode#57803 (comment)

[miniksa]

The fix for MSFT: 19205200 reached Windows mainline on October 26, 2018. It should be in Insiders builds that were created on or after that date.

[DHowett-MSFT]

... on or after that date

One such build is 18282. Can you clarify whether you're still seeing this on RS5 builds or on 19H1 builds?

[Stanzilla]

Please reconsider your downlevel merge policy, you can't expect people to use Insider builds on production machines and this is a super annoying issue.

[DHowett]

We’d love to! It’s more of a Windows policy than a Console team policy, however, so we’ll keep making noise to the appropriate people.
Thanks!

[ericblade]

Can anyone confirm that this is fixed in WinPTY, in Insiders? Code team has closed their entry on it because they are moving to the new API, but that isn't going to change the other 40 years worth of software that is no longer doing the right thing visually. :-)

I realize that no one is going to want to throw out a visual fix to the release tree on a bug fix, but i'd at least like to know if it'll be fixed for the next windows update (March?)

[Tyriar]

It's still an issue for me. @Tyriar mentioned that it will be available to us 3-4 weeks from Oct 15

@syntag pretty sure I didn't do that.

[syntag]

It's still an issue for me. @Tyriar mentioned that it will be available to us 3-4 weeks from Oct 15

@syntag pretty sure I didn't do that.

Whoops, my honest mistake. Meant to quote the user above. Edited my comment.