Explore update to Electron 3

[Tyriar]

VSCode Exploration Builds with Electron 3.0.x:

• macOS: Download
• Linux: Download
• Windows: Download

[Tyriar]

Issues so far:

• Compile error in node-pty: nan update - node-pty@0.7.5 uses nan@2.10.0
• Compile error in vscode-nsfw: nan update and code change
  • PR in upstream nsfw Fix node 10 compilation error Axosoft/nsfw#53
• Compile error in vscode-fsevents (optional dep)
• Compile error in oniguruma (dep of vscode-textmate)
  • Update nan dependency to 2.10.0 atom/node-oniguruma#80

[Tyriar]

@bpasero you'll need to re-release https://github.com/bpasero/fsevents in order to pick up nan@2.10.0

[bpasero]

@Tyriar is that a change compatible with older Electron versions or do we need a specific release only for Electron 3.x?

[Tyriar]

@bpasero it's compatible, the latest insiders is using nan@2.10 for node-pty.

[bpasero]

@Tyriar we might have to fork NSFW, I do not think that project is active anymore...

[bpasero]

@Tyriar I published vscode-chokidar@1.6.3 to try with

[Tyriar]

We already forked nsfw to vscode-nsfw to release Axosoft/nsfw#47 (repo: https://github.com/Tyriar/nsfw/tree/vscode-release)

[bpasero]

@Tyriar I pushed https://github.com/Microsoft/vscode/tree/electron-3.0.x that compiles. There are some serious issues I have not looked into, e.g. I cannot save files for some reason.

[bpasero]

I believe that one could be due to nodejs/node#2006

[Tyriar]

A lot of errors in the terminal running code.sh coming from devtools:

[Tyriar]

Saving actually does work, the first time at least. It just doesn't lose the circle indicator and then after that lots of things seem to be broken, like I cannot close the window via custom menu bar and ctrl+r doesn't work to reload.

[bpasero]

@Tyriar can you make a branch on vscode-nsfw for the NAN update, then I can remove my custom project? I am not even sure which GitHub repo that would be?

Would be cool to get a build with Electron 3 running for next weeks Electron hackathon ⭐️ . I will start with looking into the weird save issue.

[bpasero]

@rebornix @alexandrudima is this V8 change something we need to change in our code? I remember we once did changes around this where we assume a certain max string length:

(via https://v8project.blogspot.com/2017/09/v8-release-62.html)

[Tyriar]

Looks like the xterm.js parser is firing layouts in the scroll bar code in Ch66 (not in 58 or 61):

[Tyriar]

Actually this is happening in 58 and 61, it's just way faster:

Slow layouts is something we should look out for. I can look into fixing this in xterm.js as this should only be happening when a frame is rendered xtermjs/xterm.js#1606.

[bpasero]

Fyi I got NSFW working now, looks like another change for Node 10 compatibility is needed: https://github.com/bpasero/vscode-nsfw/commit/2c0ff39a2f5157fee04e407014026123e4bd3295

[bpasero]

We have our first VSCode exploration builds out (see description of the issue for download links).

[danilaml]

It's almost time to start exploring Electron 4 😄

[loligans]

Is there somewhere I can get the latest exploration build. I'd like to test out vscode in electron 3.0

[compilenix]

I don't think so, yet.

But you can build it from source How-to-Contribute#build-and-run.

[dalDevelo]

For real? There are 3 links in the original post with download links to the exploration build, depending on your OS 😳

[compilenix]

Sorry @dalDevelo , i assumed that @loligans already saw that and is not running on an OS using dmg, exe or deb packages. I.e. have Fedora which wants a rpm package.

[dalDevelo]

@compilenix. Thanks for clarifying, your response makes sense now. It's perhaps best if @loligans states his exact requirements in his post, to avoid assumptions and...in my case, confusion.

Ty

[bpasero]

It's almost time to start exploring Electron 4 😄

Yes: #61787

[pvh]

Is Electron 3 expected to be ready for the November release or not until February? I'm trying to decide whether to backport a fix in a module I use (which I will do if Electron 3 is Feb+) or just wait for the next release.

[bpasero]

@phv Q1 2019

[pvh]

Thanks, I'll backport. Not a big deal.

(PS: Improved support for binary dependencies would be welcome and I know you're tracking that elsewhere.)

[bpasero]

Merged to master for our release early February 2019. Should be available in insiders end of week.

[akmittal]

Electron 4 is released, https://electronjs.org/releases#release-notes-for-v400
It includes Chromium 69.0.3497.106 and Node 10.11.0

[bpasero]

Already builds available: #61787