Prevent infinite loop when watching circular symlinks on Linux #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an endless loop in the face of recursive symbolic links. Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
Signed-off-by: Max Brunsfeld <maxbrunsfeld@gmail.com>
|
@Tyriar thanks! I will check on this tonight :). As for the test, is stopping the watcher not sufficient for proving that we are able to exit the thread? I think stop is currently sync'd with the exit of the watching thread, so if it were looping endlessly, that may prevent a proper shutdown of that thread. edit: Also, sorry that it can take some time to get to these. I try my best to checkin at least once a month, but I have a lot of duties at work these days. |
|
I ran the test against master and it passed so I don't think the |
implausible
approved these changes
Dec 13, 2017
|
@implausible any plans for a release soon? |
|
Ping @implausible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up from #41, this pulls in that change and then stops the watcher in the test and tidies it to match the code style in the rest of the file.
While verifying the test I notice that it doesn't actually test the problem since the files are watched in an async worker so the main thread doesn't get blocked by the infinite loop. I figure it's still useful to keep.
Note that I haven't reviewed the code thoroughly coming from the commits in #41, I'll leave that up to the expert 😄
Fixes #40