-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code fails to start/open when offline #7570
Comments
@johnnyPescarul any output when you try to run |
@bpasero Sorry for the late reply, I didn't see the notification. I tried running "code --verbose" from command line and still nothing, not even one line. As soon as I connect to the internet, it works. I tried re-installing multiple times but I have the same behavior. I tried to replicate on a Windows 7 machine, but was not able to (so it seems to be limited to my Windows 8 machine). |
@johnnyPescarul does it return immediately when running "code --verbose"? |
@bpasero when I run it, it starts the process but it then hangs. It must be something early on since nothing is displayed with verbose flag on. Are there any logs generated? |
@johnnyPescarul any chance you could find out all the processes that we are able to spawn? this might get us closer to see where it hangs. @joaomoreno could this be an issue with creating a connection to the shared process if you are offline? |
@bpasero Why the shared process? The window doesn't even seem to open... |
@joaomoreno the shared process (to my understanding) gets created from the main side. we have seen super funky behaviour when sending telemetry where the entire VM stops in some DNS lookup. Maybe the main side stops in a similar situation trying to establish a connection to the shared process. |
Very unlikely. The main process doesn't even connect to it, simply spawns it. It would only block if |
I tried again to see if any processes are actually started, but no VSCode process is being started at all, when trying to start in offline mode. Unfortunately I don't have another Windows 8 machine to try and see if I can replicate the issue. |
@johnnyPescarul can you run |
@bpasero it is version 1.2.0 |
Wow, that seems to indicate a problem with Electron unless I am mistaken because we use Electron as node, correct @joaomoreno @Tyriar ? |
Here is code.cmd:
Which calls into cli.ts: export function main(args: string[]): TPromise<void> {
const argv = parseArgs(args);
if (argv.help) {
console.log(helpMessage);
} else if (argv.version) {
console.log(pkg.version);
} else ...other cases...
return TPromise.as(null);
}
main(process.argv.slice(2))
.then(() => process.exit(0))
.then(null, err => {
console.error(err.stack ? err.stack : err);
process.exit(1);
}); |
I have noticed this problem as well. Opening two visual studio code instances by running |
Can you try to see if a bare Electron app starts at least? Try with: |
I can confirm the same behaviour with the Electron app itself; both versions exhibited the same behaviour. For reference, I downloaded the following two packages and just tried running
Thanks for helping me/us narrow it down so quickly! For the moment, might it be worth adding something to the VS Code project documentation so that we don't surprise/disappoint more people trying to use the editor without an internet connection? |
@PHeonix25 please report this to https://github.com/atom/electron |
Will do, thanks @bpasero. |
Thanks for filing it 👍 |
Finally, somebody was able to replicate the issue :) Thanks @PHeonix25 . For me this was a very big issue, because I had set-up a travel laptop with my dev environment, tested everything and was relying on doing a lot of offline work on that laptop. Unfortunately when I tried to use it offline I realized it was not working, and at that time I had no option to connect and download a different IDE. Thanks anyway for the great work on VSC. |
No worries @johnnyPescarul - keep an eye on the other issue for updates. |
I'm experiencing the issue as well. |
Same for me. I like VSCode but this bug is really annoying. |
Same for me,feel so bad |
BOOO! NP++ to the rescue VS Code version
|
same problem here with the exact same resolute |
Solved by |
@Emilius449 Thank you for posting the workaround. I would prefer that they just fix it. |
Recently i just update my windows 10 to latest insider build 18290 and i see that VS code is working offline on this version so when windows 10 stable version of build will release it'll solve all the problems. |
Closing this issue given that we plan to release VSCode stable early February with Electron 3.x. If you want to benefit from the fix already, consider to use our insiders version that already contains the fix: https://code.visualstudio.com/insiders/ |
I have the same problem I thought something is wrong then I looked into google and it turns out there are many people facing the exact same issue. Please fix it ASAP. It has been happening for a month now. Before coming to this thread I was seariously looking for alternatives. Please fix it |
I think it is the best time to switch to another editor 😡😡😡 |
Experienced this just yesterday...
|
My vscode wasn't starting when offline in 2017 and few weeks ago again. Last week i was looking what is eating up all my ssd space and found an directory from code. C:\Users\xxx\AppData\Roaming\Code\Cache After starting vscode by mistake and not insiders it started fine without Internet. |
@PinkiePieStyle |
tell me how to fix this :( |
@narr07 - This is fixed. Upgrade VSC to 1.31 February 2019 release. VSC runs now on Electron 3:
|
|
|
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: