Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--install-extension CLI doesn't work under Electron 3 #56171

Closed
Tyriar opened this issue Aug 10, 2018 · 4 comments
Closed

--install-extension CLI doesn't work under Electron 3 #56171

Tyriar opened this issue Aug 10, 2018 · 4 comments
Assignees
@bpasero @Tyriar
Labels
info-needed Issue requires more information from poster

Comments

@Tyriar
Copy link
Member

Tyriar commented Aug 10, 2018

#52629

❯ code-exploration --install-extension cssho.vscode-svgviewer
(node:67029) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
Found 'cssho.vscode-svgviewer' in the marketplace.
Installing...

It just sits on Installing...
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug electron-3.0.x-update labels Aug 10, 2018
@bpasero
Copy link
Member

bpasero commented Aug 11, 2018

Good catch, this could be a regression from my stream change.

@bpasero bpasero added this to the August 2018 milestone Aug 11, 2018
@bpasero
Copy link
Member

bpasero commented Aug 11, 2018

@Tyriar seems to work for me can you try again with a later build? Are you on macOS?

image

@bpasero bpasero added the info-needed Issue requires more information from poster label Aug 11, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Aug 11, 2018

@bpasero yes macOS, will try again

@Tyriar
Copy link
Member Author

Tyriar commented Aug 13, 2018

Seems to be working on latest 👍

@Tyriar Tyriar closed this as completed Aug 13, 2018
@Tyriar Tyriar removed this from the August 2018 milestone Aug 13, 2018
@Tyriar Tyriar removed the bug Issue identified by VS Code Team member as probable bug label Aug 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@Tyriar Tyriar

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bpasero @Tyriar