Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying text still includes white space instead of newlines #2944

Closed
moritzuehling opened this issue Sep 27, 2019 · 2 comments
Closed

Copying text still includes white space instead of newlines #2944

moritzuehling opened this issue Sep 27, 2019 · 2 comments
Assignees
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone

Comments

@moritzuehling
Copy link

moritzuehling commented Sep 27, 2019

Hi everyone,

I thought this was addressed in #2797, but it didn't. It might be a duplicate of #174.

The problem

In short, copying + pasting is very weird with newlines. In some cases, it seems to copy only some of them:

image

But using clear in the WSL seems to reliably and effectively completely break copying.
image

It doesn't copy any whitespaces, instead, it copies the buffer as-is.

The same effect seems to occur with PowerShell. Here without a clear beforehand:
image

And here with a clear beforehand:
image

System info

The selected console is a standard WSL Ubuntu, as detected by the terminal:

    {
      "guid": "{2c4de342-38b7-51cf-b940-2309a097f518}",
      "hidden": false,
      "name": "Ubuntu",
      "source": "Windows.Terminal.Wsl"
    }

If it's a powershell, it's similar:

    {
      // Make changes here to the powershell.exe profile
      "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
      "name": "Windows PowerShell",
      "commandline": "powershell.exe",
      "hidden": false
    },

Nothing in the config has been changed, besides adding two (unrelated) profiles. In the screenshot, the Windows Terminal was freshly opened.

Version information of Windows Terminal:

Windows Terminal (Preview)
Version: 0.5.2681.0

System + Build Info:
image

If I can help with providing anything else, please do ask.

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 27, 2019
@moritzuehling
Copy link
Author

Since I wanted to be a bit proactive, here is a small workaround I've written: https://github.com/moritzuehling/WindowsTerminalClipboardFixup

@DHowett-MSFT DHowett-MSFT added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Sep 30, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 30, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 30, 2019
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Sep 30, 2019
@moritzuehling
Copy link
Author

Seems to be fixed in the newest version, closing! Thank you for fixing it ♥

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Nov 30, 2019
gbaychev added a commit to gbaychev/terminal that referenced this issue Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

3 participants