Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Profile, ColorScheme, GlobalAppSettings proper WinRT types #3998

Closed
zadjii-msft opened this issue Dec 17, 2019 · 1 comment
Closed

Make Profile, ColorScheme, GlobalAppSettings proper WinRT types #3998

zadjii-msft opened this issue Dec 17, 2019 · 1 comment
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

Right now they're plain old c++ classes. If we want extensions to be able to modify them, add their own, etc, then we'll need them to be projected as proper WinRT types.
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Dec 17, 2019
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Dec 17, 2019
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 17, 2019
@zadjii-msft zadjii-msft added the Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. label Dec 17, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 17, 2019
@zadjii-msft zadjii-msft mentioned this issue Dec 17, 2019
Open
8 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 19, 2019
@zadjii-msft zadjii-msft mentioned this issue Mar 18, 2020
Closed
4 tasks
zadjii-msft added a commit that referenced this issue Mar 18, 2020
@zadjii-msft
Try to clone the settings directly from the control
908fd74 
  Okay this is harder, but maybe not impossible, but probably impossible in v1.

  The Profile knows how to build the connection settings, and the
  ControlSettings, etc. However, when the settings reloads like in this bug,
  we'll remove all the old profiles, and build a new list.

  If we wanted the case 1 behavior, we could wait until the Profile is a winrt
  object, then have each Pane hold a strong ref to the Profile that it's
  hosting. Then it would be trivial to be able to duplicate the settings from
  it. I believe that work is tracked in #3998.

  How palatable is doing case 3 now (to fix the crash), then filing a follow up
  to do case 1 once #3998 is done?
@zadjii-msft zadjii-msft mentioned this issue Mar 20, 2020
Open
@zadjii-msft
Copy link
Member Author

You know, @carlos-zamora actually did this over the course of the last year.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
3 participants
@carlos-zamora @DHowett-MSFT @zadjii-msft