Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Choose Direction to Split Pane #4340

Closed
LowellBateman opened this issue Jan 23, 2020 · 2 comments · Fixed by #11145
Closed

Choose Direction to Split Pane #4340

LowellBateman opened this issue Jan 23, 2020 · 2 comments · Fixed by #11145
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@LowellBateman
Copy link

Description of the new feature/enhancement

Sometimes I like to have my panes organized in a specific way. This can be difficult when you are only allowed to split to the right or below. I suggest adding commands to split above and to the left. I know conemu was capable of splitting panes in any direction.

Proposed technical implementation details (optional)

Add splitUp, splitDown, splitLeft, splitRight commands instead of / in addition to splitHorizontal, splitVertical
@LowellBateman LowellBateman added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 23, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 23, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jan 23, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 23, 2020
@zadjii-msft zadjii-msft mentioned this issue Jan 23, 2020
Open
59 tasks
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 23, 2020
@DHowett-MSFT
Copy link
Contributor

Since this has been accumulated into the Panes deliverable, #1000, I'm yanking the Triage tag.

@Rosefield Rosefield mentioned this issue Sep 4, 2021
Merged
6 tasks
@ghost ghost closed this as completed in #11145 Sep 15, 2021
ghost pushed a commit that referenced this issue Sep 15, 2021
@Rosefield
Add the ability to split a pane and put the new pane first. (#11145)
87b695f 
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? -->
## Summary of the Pull Request
Adds directional modifiers for SplitState and convert those to the appropriate horizontal/vertical when splitting a pane.

<!-- Other than the issue solved, is this relevant to any other issues/existing PRs? --> 
## References

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [x] Closes #4340
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA
* [ ] Tests added/passed
* [x] Documentation updated. If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/terminal) and link it here: #xxx
* [x] Schema updated.
* [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
"vertical" and "horizontal" splits were removed from `defaults.json`, but code was added to parse those as `right` and `down` respectively. It is also the case that if a user has a custom hotkey for `split: vertical` it will override the default for `split: right`.

<!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed
Split the pane using each of the new directional movements
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 15, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11145, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add the ability to split a pane and put the new pane first. Rosefield/terminal
3 participants
@DHowett-MSFT @LowellBateman @zadjii-msft