Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't let results hide under search box #4407

Closed
Tracked by #3920
fredless opened this issue Jan 30, 2020 · 4 comments · Fixed by #17516
Closed
Tracked by #3920

Don't let results hide under search box #4407

fredless opened this issue Jan 30, 2020 · 4 comments · Fixed by #17516
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@fredless
Copy link

fredless commented Jan 30, 2020 •
edited
Loading

Description of the new feature/enhancement

Sometimes a search result can hide under the search box, this is confusing to the uninitiated. Search should always show the found item without hiding it under a UI element.
hidingUnderSearchBox

Proposed technical implementation details (optional)

Perhaps scroll the search result further up to pad it away from the search box in most situations - not very elegant though.
@fredless fredless added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 30, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 30, 2020
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Task It's a feature request, but it doesn't really need a major design. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Jan 30, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jan 30, 2020
@zadjii-msft zadjii-msft removed the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jan 30, 2020
@zadjii-msft
Copy link
Member

I think you've got a good point here.

@DHowett-MSFT
Copy link
Contributor

Yep, this is reasonable.

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 31, 2020
@DHowett-MSFT DHowett-MSFT added this to the Terminal v1.0 milestone Jan 31, 2020
@DHowett-MSFT
Copy link
Contributor

Moved to v1.0 - we can talk about this in a later scrub. 😄

@cinnamon-msft cinnamon-msft added the Help Wanted We encourage anyone to jump in on these. label Feb 28, 2020
@carlos-zamora carlos-zamora self-assigned this May 12, 2020
@carlos-zamora
Copy link
Member

Also tagging this to #3920 since this would be something nice to deliver as a part of an updated Search experience.

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
This was referenced Sep 14, 2022
Open
Closed
@carlos-zamora carlos-zamora removed their assignment Oct 28, 2022
@zadjii-msft zadjii-msft moved this to Should be written in Terminal Walkthroughs Feb 6, 2023
@zadjii-msft zadjii-msft mentioned this issue Apr 29, 2024
Closed
@e82eric e82eric mentioned this issue Jul 4, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Jul 4, 2024
@lhecker lhecker closed this as completed in 0bafab9 Aug 7, 2024
@github-project-automation github-project-automation bot moved this from Should be written to Done in Terminal Walkthroughs Aug 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Aug 7, 2024
DHowett pushed a commit that referenced this issue Sep 24, 2024
@e82eric @DHowett
Avoid covering current search highlight with search box (#17516)
d1ac375 
Adds a scroll offset to avoid hiding the current search highlight with
the search box.
- Offset is based on the number of rows that the search box takes up.
  (I am not totally sure I am calculating this right)
- This won't help when the current highlight is in the first couple
  rows of the buffer.

Fixes: #4407
(cherry picked from commit 0bafab9)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmszgTTNTE
Service-Version: 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Terminal Walkthroughs
Status: Done
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Avoid covering current search highlight with search box e82eric/terminal
6 participants
@DHowett @carlos-zamora @DHowett-MSFT @fredless @zadjii-msft @cinnamon-msft