Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEGATHREAD: Commandline Args Follow-Up Work #4632

Open
20 of 40 tasks
zadjii-msft opened this issue Feb 18, 2020 · 9 comments
Open
20 of 40 tasks

MEGATHREAD: Commandline Args Follow-Up Work #4632

zadjii-msft opened this issue Feb 18, 2020 · 9 comments
Labels
Area-Commandline wt.exe's commandline arguments Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Scenario Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Feb 18, 2020

Reference

Untriaged Bugs/Features

1.0 Bugs

The Help Dialog

Post 1.0 features

2.0 Bugs

Backlog

Discussion

Other related discussion
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Feb 18, 2020
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Scenario Product-Terminal The new Windows Terminal. labels Feb 18, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Feb 18, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Feb 18, 2020
@DHowett-MSFT DHowett-MSFT added the Area-Commandline wt.exe's commandline arguments label Feb 18, 2020
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Feb 21, 2020
@DHowett-MSFT
Copy link
Contributor

I've moved #4619, #4618 and and #4602 into the v1.0 milestone.

@Karl-WE
Copy link

Karl-WE commented Feb 23, 2020

for any new args please consider reading and support this feature request before it get's out of control / focus.
Reference #4601

@WSLUser
Copy link
Contributor

WSLUser commented Apr 23, 2020

@zadjii-msft Please add #5494 to the list to add -v, --version to the list of args. All other Windows apps (linux apps too, but different arg) allow viewing the version via CLI (even if we need it to simply open up the About page).

ghost pushed a commit that referenced this issue May 4, 2020
ghost pushed a commit that referenced this issue Jun 1, 2020
## Summary of the Pull Request

Adds two new flags to the `wt.exe` alias:

* `--maximized,-M`: Launch the new Terminal window maximized. This flag cannot be combined with `--fullscreen`.
* `--fullscreen,-F`: Launch the new Terminal window fullscreen. This flag cannot be combined with `--maximized`.

## References
* This builds on the work done in #6060.
* The cmdline args megathread: #4632

## PR Checklist
* [x] Closes #5801
* [x] I work here
* [ ] Tests added/passed
* [n/a] Requires documentation to be updated

## Detailed Description of the Pull Request / Additional comments

* I had to move the commandline arg parsing up a layer from `TerminalPage` to `AppLogic`, because `AppLogic` controls the Terminal's settings, including launch mode settings. This seems like a reasonable change, to put both the settings from the file and the commandline in the same place.
  - **Most of the diff is that movement of code**

* _"What happens when you try to pass both flags, like `wtd -M -F new-tab`?"_:
![image](https://user-images.githubusercontent.com/18356694/82679939-3cffde00-9c11-11ea-8d88-03ec7db83e59.png)

## Validation Steps Performed
* Ran a bunch of commandlines to see what happened.
@Guiorgy
Copy link

Guiorgy commented Aug 19, 2020

Windows commandline args are usually /fooBar but ours are --fooBar and that's weird

Is there an open discussion for this, or is this only internal for now?

@zadjii-msft
Copy link
Member Author

@Guiorgy I don't think there's a current nogoing discussion, but there's mot really any chance that we'll change this, considering that 1.0 has already shipped with --fooBar args.

As we discovered over in #4601 (comment), it turns out that /fooBar style params will actually secretly work as well, but we're not officially documenting that in case CLI11 ever changes that out from underneath us.

@Guiorgy
Copy link

Guiorgy commented Aug 19, 2020

@zadjii-msft Oh wow, it does work! 😃
Anyways, glad to hear that -- isn't going anywhere. Personally, I hope you officially support both at some point.

ghost pushed a commit that referenced this issue Oct 14, 2020
This commit introduces two new launch modes: focus and maximizedFocus. 
* Focused mode, behaves like a default mode, but with the Focus Mode
  enabled.
* Maximized focused mode, behaves like a Maximized mode, but with the
  Focus Mode enabled.

There two ways to invoke these new modes:
* In the settings file: you set the "launchMode" to either "focus" or
  "maximizedFocus"
* In the command line options, you can path -f / --focus, which is
  mutually exclusive with the --fullscreen, but can be combined with the
  --maximized:
  * Passing -f / --focus will launch the terminal in the "focus" mode
  * Passing -fM / --focus --maximized will launch the terminal in the
    "maximizedFocus" mode

This should resolve a relevant part in the command line arguments
mega-thread #4632

Closes #7124
Closes #7825
Closes #7875
@rashil2000
Copy link
Contributor

Sorry, I couldn't find any documentation, but are --height or --width options for launching new window planned/supported?

(Use case: a desktop shortcut for opening neovim in WT. I'd like that window to be larger than what I have normally set for the terminal in settings.json through the initialRows and initialCols options)

@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: Backlog, Megathreads Jan 18, 2022
@honeylizard
Copy link

After opening a WLS profile (e.g. Ubuntu), is there anyway to pass Unix style commands?

Running wt.exe new-tab -p Ubuntu cd /example/path opens the tab, but the terminal shows the error

[error 0x80070002 when launching 'cd /example/path']

All the examples I've found so far show how to run Windows commands after a new-tab call, but nothing on unix/linux commands...

@htcfreek
Copy link

und so far show how to run Windows commands after a new-tab call, but nothing on unix/linux commands...

Same for me with PowerShell or other profiles. I opened the issue #16062 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Commandline wt.exe's commandline arguments Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Scenario Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

8 participants