Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify number of lines for scollUp and scrollDown commands (+ follow system setting?) #5078

Closed
Livven opened this issue Mar 22, 2020 · 6 comments · Fixed by #7924
Closed

Specify number of lines for scollUp and scrollDown commands (+ follow system setting?) #5078

Livven opened this issue Mar 22, 2020 · 6 comments · Fixed by #7924
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@Livven
Copy link

Livven commented Mar 22, 2020

Description of the new feature/enhancement

It would be nice if the scrollUp and scrollDown commands supported a lines argument that would specify how many lines to scroll.

Alternatively or additionally, it might make sense to set the default to the number of lines the mouse wheel is set to scroll, i.e. usually 3. This seems more useful to me as a default than just scrolling a single line, which is very slow, or scrolling a whole page, which can be jarring (at least without smooth scrolling #1400).

Proposed technical implementation details (optional)
@Livven Livven added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 22, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 22, 2020
@DHowett-MSFT
Copy link
Contributor

We've got a global setting, "rowsToScroll", that configures how many lines to scroll with the wheel. If you do not set it, it defaults to your system setting (as set in the Mouse settings page.) If I recall, that default on Windows is 3.
If you're using a precision trackpad, that setting should still apply.

@DHowett-MSFT DHowett-MSFT added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Mar 22, 2020
@Livven
Copy link
Author

Livven commented Mar 22, 2020

I was talking about the keyboard-bindable commands :)

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Mar 22, 2020
@zadjii-msft
Copy link
Member

You know, when I first spec'd arguments for keybindings, I called out scrollUp and scrollDown as two actions that needed args for customizable values. Looks like that never got turned into an actual issue.

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Attention The core contributors need to come back around and look at this ASAP. labels Mar 23, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 23, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Mar 23, 2020
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Mar 23, 2020
@Livven Livven closed this as completed Mar 23, 2020
@Livven Livven reopened this Mar 23, 2020
@Livven
Copy link
Author

Livven commented Mar 23, 2020

@zadjii-msft For me personally it would actually be enough if the value was simply linked to rowsToScroll or the Windows mouse wheel setting, because that already fixes the issue of scrolling by just 1 line being super slow. But of course additional customization doesn't hurt.

(accidentally hit the close issue button there)

@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 24, 2020
@DHowett-MSFT DHowett-MSFT changed the title Specify number of lines for scollUp and scrollDown commands (+ better default?) Specify number of lines for scollUp and scrollDown commands (+ follow system setting?) Mar 24, 2020
@DHowett-MSFT
Copy link
Contributor

Thanks! Triaged this onto the backlog, but marked it Help-Wanted. If somebody were to implement this before v1, I'd almost certainly pull it in.

@Don-Vito Don-Vito mentioned this issue Oct 15, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Oct 15, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Oct 27, 2020
DHowett pushed a commit that referenced this issue Oct 27, 2020
@Don-Vito
add rowsToScroll to scrollUp/Down w/ fallback to system default (#7924)
b3aab8c 
- The number of lines to move upon scroll up scroll down can be defined
  in ScrollUp and ScrollDown commands (parameter is called
  "rowsToScroll").
- If the number are not provided, use the system default (the one we are
  using for mouse scrolls), rather than 1 line.

## Validation Steps Performed
* Manual testing
* Added custom bindings for scroll commands with different values,
  verified they and the default appear and behave as expected
* Checked that invalid values are not allowed

Closes #5078
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Oct 27, 2020
@ghost
Copy link

ghost commented Nov 11, 2020

🎉This issue was addressed in #7924, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

add rowsToScroll to scrollUp/Down w/ fallback to system default Don-Vito/terminal
3 participants
@Livven @DHowett-MSFT @zadjii-msft