[Feature-request] Minimize to tray #5727

manojvignesh · 2020-05-04T03:49:06Z

Description of the new feature/enhancement

Add an option to minimize to tray instead of task bar.
It can be a setting when enabled, always minimize the terminal to tray.
I also like the option in cmder where right click on close minimizes to tray in that way i have both the minimize to tray and taskbar available to me always.
It need not be exactly like right click on close button, it can be a shortcut too.

On reopening of terminal minimized to tray:
It'd be good if opening of terminal from taskbar icon reopen the minimized instance of terminal and not a new one. Though i can work around it using the win + b shortcut.

zadjii-msft · 2020-05-04T13:14:31Z

This is an entirely reasonable feature request, one that would probably mix well with #653 and #5000. Thanks!

NicTanghe · 2020-05-27T19:03:44Z

Anny ita on picking this up ?
like in about how manny releases focus can shift to include this HQ feature.

zadjii-msft · 2020-05-28T14:16:00Z

@NicTanghe Nope, no ETA, as indicated by the milestone of this issue:

NeuroAssassin · 2020-06-02T20:06:24Z

Interested in this as well, as I usually have a lot of windows open and it'd be nice to move this one out of the way.

aalouaoui · 2020-06-10T15:13:53Z

This is why I am still using cmder instead of windows terminal. If they add it I will switch to Windows Terminal

sarahelsaig · 2020-09-04T01:48:48Z

Would it be okay to add a minimize to tray button at the bottom of the New Tab dropdown menu? That would make the feature (and the hotkey) intuitively discoverable as opposed to the right click on close idea which feels like a secret if you don't already come from a cmder background and expect it.

It'd be good if opening of terminal from taskbar icon reopen the minimized instance of terminal and not a new one.

I think that's covered separately by single instance mode (#2227).

Mystik01 · 2020-11-21T12:55:02Z

If I could upvote this i would

DHowett · 2020-11-21T20:39:49Z

@Mystik01 other folks appear to have figured out how to upvote issue comments

Please use that.

levicki · 2021-01-07T04:23:03Z

If this gets implemented please consider not breaking standard UI behavior by introducing stuff like right-click on close button but instead use minimize so it can be done using keyboard shortcuts as well.

### ⇒ [doc link](https://github.com/microsoft/terminal/blob/dev/migrie/s/653-quake-mode/doc/specs/%23653%20-%20Quake%20Mode/%23653%20-%20Quake%20Mode.md) ⇐ ## Summary of the Pull Request After reading through 114+ comments in #653 and related issues, I think I've finally wrapped my head around all the possible scenarios for quake mode.  This also includes "minimize to tray", because the two are a powerful combination. With the work already prototyped in [`dev/migrie/f/653-QUAKE-MODE`](https://github.com/microsoft/terminal/tree/dev/migrie/f/653-QUAKE-MODE), [I'm starting to believe](https://j.gifs.com/58vKNx.gif) that we could actually land this in 2.0. ### Abstract > Many existing terminals support a feature whereby a user can press a keybinding > anywhere in the OS, and summon their terminal application. Oftentimes the act of > summoning this window is accompanied by a "dropdown" animation, where the window > slides in to view from the top of the screen. This global summon action is often > referred to as "quake mode", a reference to the videogame Quake who's console > slid in from the top. > > This spec addresses both of the following two issues: > * "Quake Mode" ([#653]) > * "Minimize to tray" ([#5727]) ## PR Checklist * [x] Specs: #653, #5727 * [x] References: #5000, #4472, #2227, #7240, #8135 * [x] I work here ## Detailed Description of the Pull Request / Additional comments _\*\*\* read the spec \*\*\*_

juventus18 · 2021-05-06T18:44:58Z

I'm using https://github.com/flyingpie/windows-terminal-quake to put WT in the tray instead of taskbar

@DHowett

## Summary of the Pull Request This is a scoped implementation of "hide on minimize", only to the `_quake` window. When minimized, the `_quake` window won't appear in the taskbar. IT ALSO WON'T APPEAR IN THE TRAY, BECAUSE WE DON'T HAVE ONE YET. I talked about this with @DHowett, and it seemed cool. Other windows will still minimize normally. ## References * Original thread: #653 * Spec: #9274 * megathread: #8888 * minimize to tray: #5727 ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/projects/5#card-61246940 * [x] I work here * [ ] Tests added/passed * [ ] Requires documentation to be updated - probably yea, but something something something ## Detailed Description of the Pull Request / Additional comments After playing with it, it is in fact, cool. ALSO `LOG_IF_WIN32_BOOL_FALSE` should DEFINITELY not be used with `ShowWindow`. [`ShowWindow`](https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-showwindow#return-value) returns false if the window was previously hidden, but doesn't `SetLastError`, so that macro will _throw_. ## Validation Steps Performed ```jsonc { "keys": "ctrl+`", "command": { "action": "quakeMode" } }, { "keys": "ctrl+1", "command": { "action": "globalSummon", "name": "_quake" } }, // { "keys": "ctrl+1", "command": { "action": "globalSummon" } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "desktop": "toCurrent" } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "toggleVisibility": false } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "dropdownDuration": 2000 } }, { "keys": "ctrl+2", "command": { "action": "globalSummon", "monitor": "any" } }, // { "keys": "ctrl+3", "command": { "action": "globalSummon", "desktop": "onCurrent" } }, { "keys": "ctrl+3", "command": { "action": "globalSummon", "monitor": "toMouse" } }, // { "keys": "ctrl+4", "command": { "action": "globalSummon", "desktop": "any" } }, { "keys": "ctrl+4", "command": { "action": "globalSummon", "monitor": "toMouse", "dropdownDuration": 500 } }, { "keys": "ctrl+5", "command": { "action": "globalSummon", "dropdownDuration": 500 } }, ```

orcmid · 2021-06-15T14:40:57Z

I'm a little concerned how this interacts with there being multiple terminal sessions (not tabbed), as when some app launches wired to a (new) terminal instance.

WSLUser · 2021-06-15T15:05:25Z

The logic for the tray icon will have to be updated to be smart enough to know when a new window is opened while the tray icon exists for another window and a user decides to minimize that one too, otherwise that window should be ignored. It should also provide the choices to summon a specific window or all windows (we'll need to be careful here as it could cause a large perf impact trying to restore potentially a bunch of windows and ensure they're summoned in a way to keeps resources down as much as possible).

orcmid · 2021-06-15T17:39:18Z

@WSLUser the task bar already handles the multiple instance case quite nicely, and indicates when there are running instances. I suspect we are asking too much of the tray, which regularly hides some instances it is keeping hot (like Discord which I can't keep from going to the tray, while Zoom at least goes to the task bar and forcing quit is easier).

WSLUser · 2021-06-16T14:03:00Z

Well there are a great many applications where what I've described occurs, usually with some kind of perf cost that can cause the machine (or monitor/GPU at least) to freeze up for a moment.

This PR is a small start in a broader "Minimize to Tray" feature (#5727). This particular change is scoped only to the scenario when a quake window is minimized. Currently the only way to bring back the quake window when it's minimized is to press the global hotkey again. This gives another option - to press the terminal icon in the tray. Eventually though, minimize to tray will be available for any window, and I'd like more time to flesh out the general porpoise scenarios and context menus. Having just a bit in this PR also helps reviewers by keeping it small!

A brief summary of the behavior of the tray icon: - There will only ever be one tray icon representing all windows. - Left-Click on a Tray Icon brings up the MRU window. - Right-Click on a Tray Icon brings up a Context Menu: ``` Focus Terminal ---------------- Windows --> Window ID 1 - <unnamed window> Named Window Named Window Again ``` - Focus Terminal will bring up the MRU window. - Clicking on any of the Window "names" in the submenu will summon the window. ## Settings Changes Two new global settings are introduced: `alwaysShowTrayIcon` and `minimizeToTray`. Here's a chart explaining the behavior with the two settings. | | `alwaysShowTrayIcon:true` | `alwaysShowTrayIcon:false` | |----------------------|------------------------------------------------------------------|------------------------------------------------------------------| | `minimizeToTray:true` | tray icon is always shown. minimize button will hide the window. | tray icon is always shown. minimize button will hide the window. | | `minimizeToTray:false` | tray icon is always shown. | tray icon is not shown ever. | Closes #5727 ## References [Spec for Minimize to Tray](https://github.com/microsoft/terminal/blob/main/doc/specs/%23653%20-%20Quake%20Mode/%23653%20-%20Quake%20Mode.md#minimize-to-tray) Docs PR - MicrosoftDocs/terminal#352 #10448 - My list of TODOs

manojvignesh added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 4, 2020

ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 4, 2020

zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels May 4, 2020

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 4, 2020

zadjii-msft added this to the Terminal Backlog milestone May 4, 2020

DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 5, 2020

zadjii-msft mentioned this issue Jul 20, 2020

Feature request: hot key drop down ala quake/guake/tilda #653

Closed

This comment has been minimized.

Sign in to view

j4james mentioned this issue Jan 7, 2021

Could you pls add Minimize to Taskbar Status Area #8717

Closed

zadjii-msft mentioned this issue Feb 12, 2021

Toggle terminal to and from dock #9131

Closed

zadjii-msft mentioned this issue Feb 24, 2021

Spec for Quake Mode #9274

Merged

3 tasks

skyline75489 mentioned this issue Apr 19, 2021

Feature Request - Hotkey Toggle to Minimize/Maximize Terminal #9885

Closed

zadjii-msft modified the milestones: Terminal Backlog, Terminal v1.10 May 17, 2021

zadjii-msft mentioned this issue May 17, 2021

Hide _quake window on minimize ALWAYS #10113

Merged

4 tasks

zadjii-msft assigned leonMSFT May 21, 2021

leonMSFT mentioned this issue May 25, 2021

Add tray icon when quake window is minimized #10179

Merged

leonMSFT mentioned this issue Jun 8, 2021

Add Minimize to Tray and Tray Icon #10368

Merged

skyline75489 mentioned this issue Jun 15, 2021

Add ability to run in background #10419

Closed

leonMSFT mentioned this issue Jun 17, 2021

Tray Icon feature improvements and follow-ups #10448

Open

15 tasks

ghost added the In-PR This issue has a related PR label Jun 22, 2021

cinnamon-msft modified the milestones: Terminal v1.10, Terminal v1.11 Jul 14, 2021

ghost closed this as completed in #10368 Aug 12, 2021

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Aug 12, 2021

zadjii-msft mentioned this issue Oct 23, 2021

Need a back-end Terminal #11588

Closed

tfiers mentioned this issue Jan 22, 2022

Minimize to tray not working #12220

Closed

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature-request] Minimize to tray #5727

[Feature-request] Minimize to tray #5727

manojvignesh commented May 4, 2020 •

edited

Loading

zadjii-msft commented May 4, 2020

NicTanghe commented May 27, 2020

zadjii-msft commented May 28, 2020

NeuroAssassin commented Jun 2, 2020

aalouaoui commented Jun 10, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sarahelsaig commented Sep 4, 2020

Mystik01 commented Nov 21, 2020

DHowett commented Nov 21, 2020

levicki commented Jan 7, 2021

juventus18 commented May 6, 2021

orcmid commented Jun 15, 2021

WSLUser commented Jun 15, 2021

orcmid commented Jun 15, 2021 •

edited

Loading

WSLUser commented Jun 16, 2021 •

edited

Loading

[Feature-request] Minimize to tray #5727

[Feature-request] Minimize to tray #5727

Comments

manojvignesh commented May 4, 2020 • edited Loading

Description of the new feature/enhancement

zadjii-msft commented May 4, 2020

NicTanghe commented May 27, 2020

zadjii-msft commented May 28, 2020

NeuroAssassin commented Jun 2, 2020

aalouaoui commented Jun 10, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sarahelsaig commented Sep 4, 2020

Mystik01 commented Nov 21, 2020

DHowett commented Nov 21, 2020

levicki commented Jan 7, 2021

juventus18 commented May 6, 2021

orcmid commented Jun 15, 2021

WSLUser commented Jun 15, 2021

orcmid commented Jun 15, 2021 • edited Loading

WSLUser commented Jun 16, 2021 • edited Loading

manojvignesh commented May 4, 2020 •

edited

Loading

orcmid commented Jun 15, 2021 •

edited

Loading

WSLUser commented Jun 16, 2021 •

edited

Loading