-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use "default" system sound for terminal bell/beep, as opposed to "critical". #6568
Comments
As opposed to the "Critical" system sound. Fixes microsoft#6568.
So, Terminal doesn't actually support the bell right now. The code you've identified is part of the vintage console host--and I'm not about to change how belling works in the vintage console host. This will become meaningful when we do finally implement bell for Terminal: /dup #4046 |
Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report! |
(I appreciate that you're working on a PR for this 😄 I just wanted to get out ahead of it!) |
Oof thanks for the quick respo <3 I'll drop that then, haha. Understood - here's to hoping, I'll thumb up the other issue, thanks! I'll keep my own fork around, because maybe I'll try to build it and fix it on my own machine, heh. |
👍 We offer no warranty for this, but if you want to replace conhost.exe (system32, subject to system file protection) with openconsole.exe built out of this repo. . . I can't stop you! (it's the exact same code that gets built and packaged with Windows, it can just move a whole lot faster because it's out here in the open!) |
I feel that the "Critical Stop" sound, also known as "SystemHand" or, as referenced here,
SND_ALIAS_SYSTEMHAND
, is too "critical"/high-priority of an audible feedback for a console beep - it plays out for too long and doesn't 'attack' as quickly as a neutral/default UI bell sound would.As a counterexample, Ubuntu uses a low and quick hollow "thunk" sound. Mac has Sosumi, Funk, and so forth, for the Terminal beep.
I'd suggest replacing that in the Windows Terminal with
SND_ALIAS_SYSTEMDEFAULT
- the "Default Beep", as it's called in the Sound control panel.(I'm not sure why Critical Stop was chosen here - if there is a persuasive reason (Human Interface Guidelines, for instance) then it's probably best to stay as such.)
I'll be making a PR which changes that one line, and I'll refer to this issue in the PR.
Usecases: cmd.exe, Ubuntu/WSL, rarely PowerShell.
ver
isMicrosoft Windows [Version 10.0.18363.900]
conhost.exe
is as shipped, with latest Windows Updates installed - file/product version is10.0.18362.1
.The text was updated successfully, but these errors were encountered: