Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "default" system sound for terminal bell/beep, as opposed to "critical". #6568

Closed
sirocyl opened this issue Jun 18, 2020 · 5 comments
Closed
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@sirocyl
Copy link

sirocyl commented Jun 18, 2020

I feel that the "Critical Stop" sound, also known as "SystemHand" or, as referenced here, SND_ALIAS_SYSTEMHAND, is too "critical"/high-priority of an audible feedback for a console beep - it plays out for too long and doesn't 'attack' as quickly as a neutral/default UI bell sound would.

As a counterexample, Ubuntu uses a low and quick hollow "thunk" sound. Mac has Sosumi, Funk, and so forth, for the Terminal beep.

I'd suggest replacing that in the Windows Terminal with SND_ALIAS_SYSTEMDEFAULT - the "Default Beep", as it's called in the Sound control panel.

(I'm not sure why Critical Stop was chosen here - if there is a persuasive reason (Human Interface Guidelines, for instance) then it's probably best to stay as such.)

I'll be making a PR which changes that one line, and I'll refer to this issue in the PR.

Usecases: cmd.exe, Ubuntu/WSL, rarely PowerShell.
ver is Microsoft Windows [Version 10.0.18363.900]
conhost.exe is as shipped, with latest Windows Updates installed - file/product version is 10.0.18362.1.

@sirocyl sirocyl added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 18, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jun 18, 2020
sirocyl added a commit to sirocyl/terminal that referenced this issue Jun 18, 2020
As opposed to the "Critical" system sound. Fixes microsoft#6568.
@DHowett
Copy link
Member

DHowett commented Jun 18, 2020

So, Terminal doesn't actually support the bell right now. The code you've identified is part of the vintage console host--and I'm not about to change how belling works in the vintage console host.

This will become meaningful when we do finally implement bell for Terminal: /dup #4046

@ghost
Copy link

ghost commented Jun 18, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jun 18, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 18, 2020
@DHowett
Copy link
Member

DHowett commented Jun 18, 2020

(I appreciate that you're working on a PR for this 😄 I just wanted to get out ahead of it!)

@sirocyl
Copy link
Author

sirocyl commented Jun 18, 2020

Oof thanks for the quick respo <3

I'll drop that then, haha. Understood - here's to hoping, I'll thumb up the other issue, thanks!

I'll keep my own fork around, because maybe I'll try to build it and fix it on my own machine, heh.

@DHowett
Copy link
Member

DHowett commented Jun 18, 2020

👍

We offer no warranty for this, but if you want to replace conhost.exe (system32, subject to system file protection) with openconsole.exe built out of this repo. . . I can't stop you!

(it's the exact same code that gets built and packaged with Windows, it can just move a whole lot faster because it's out here in the open!)

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Development

No branches or pull requests

2 participants