-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scenario: Improved support for different graphics renditions [VT, SGR] #6879
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
SGR 53 (overlined) was introduced in ECMA-48 4th edition. And thanks for implementing it. |
Are there plans to actually support bold typeface? I know there was some heavy discussion in #2916, but it doesn't seem like a consensus was reached. Personally I'd love to see proper support for bold typefaces as a heavy WSL and Solarized user. |
Bold is actually being tracked by #109, whenever we get around to it |
Updated for Blink in 1.4+ |
This is my attempt to isolate all the dwrite font related thing by introducing a new layer - `DxFontRenderData`. This will free `DxRenderer` & `CustomTextLayout` from the burden of handling fonts & box effects. The logic is more simplified & streamlined. In short I just moved everything fonts-related into `DxFontRenderData` and started from there. There's no modification to code logic. Just pure structural stuff. SGR support tracking issue: #6879 Initial Italic support PR: #8580
This commit adds support for bold text in DxRenderer. For now, bold fonts are always rendered using DWRITE_FONT_WEIGHT_BOLD regardless of the base weight. As yet, this behavior is unconfigurable. References Previous refactoring PRs: #9096 (DxFontRenderData) #9201 (DxFontInfo) SGR support tracking issue: #6879 Closes #109
Huh, IIRC Italic is already supported since #8580, right? And of course, bold doesn't break Italic. My refactoring PRs were designed to support both features. |
Supported
1
Intensity (Bright)1
Intensity (Bold Weight)2
Faint3
Italic4
Underlineas of v1.3, underline is rendered per font metrics
5
Blink7
Reverse Video8
Conceal/Invisible9
Crossed Out21
Doubly Underlined53
OverlineUnsupported, Planned
(kitty)
Unsupported, Unplanned
(mintty)
Miscellaneous Related Issues
:
for subparameter separators instead of;
38
,48
; see terminfo here)The text was updated successfully, but these errors were encountered: