Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scenario: Improved support for different graphics renditions [VT, SGR] #6879

Open
1 task
DHowett opened this issue Jul 12, 2020 · 7 comments
Open
1 task

Scenario: Improved support for different graphics renditions [VT, SGR] #6879

DHowett opened this issue Jul 12, 2020 · 7 comments
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-VT Virtual Terminal sequence support Issue-Scenario Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal.
Milestone
Megathreads

Comments

@DHowett
Copy link
Member

DHowett commented Jul 12, 2020 •
edited by zadjii-msft
Loading

Supported

Attribute Standard Stored Rendered As of Notes
1 Intensity (Bright) VT100 ✔ ✔ Always
1 Intensity (Bold Weight) VT100 ✔ ✔ v1.10 #109, #5682, #2916 (comment)
2 Faint ECMA-48 2nd ✔ ✔ v1.3 #6703 / #6873
3 Italic ECMA-48 2nd ✔ ✔ v1.9 #5461
4 Underline ECMA-48 2nd ✔ ✔ Always #6911
as of v1.3, underline is rendered per font metrics
5 Blink VT100 ✔ ✔ v1.4 #7388
7 Reverse Video VT100 ✔ ✔ Always
8 Conceal/Invisible ECMA-48 2nd ✔ ✔ v1.3 #6876
9 Crossed Out ECMA-48 2nd ✔ ✔ v1.3 #6205
21 Doubly Underlined ECMA-48 3rd ✔ ✔ v1.3 #2916
53 Overline ECMA-48 4th ✔ ✔ v1.2 #6000

Unsupported, Planned

Attribute Standard Stored Rendered Notes
Fancy Underlines
(kitty)		 none ❌ ❌ #7228

Unsupported, Unplanned

Attribute Standard Stored Rendered Notes
Extended Fonts
(mintty)		 none ❌ ❌ #6779, unplanned

Miscellaneous Related Issues
@DHowett DHowett added Product-Conhost For issues in the Console codebase Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-VT Virtual Terminal sequence support Product-Terminal The new Windows Terminal. Issue-Scenario labels Jul 12, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Jul 12, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 12, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 12, 2020
@DHowett DHowett mentioned this issue Jul 13, 2020
Closed
@jdebp

This comment has been minimized.

Sign in to view
@DHowett

This comment has been minimized.

Sign in to view
@DHowett DHowett mentioned this issue Aug 8, 2020
Closed
@rbanffy
Copy link

rbanffy commented Aug 10, 2020

SGR 53 (overlined) was introduced in ECMA-48 4th edition. And thanks for implementing it.

@Nosamdaman
Copy link

Are there plans to actually support bold typeface? I know there was some heavy discussion in #2916, but it doesn't seem like a consensus was reached. Personally I'd love to see proper support for bold typefaces as a heavy WSL and Solarized user.

@zadjii-msft
Copy link
Member

Bold is actually being tracked by #109, whenever we get around to it ☺️

@DHowett
Copy link
Member Author

DHowett commented Sep 21, 2020

Updated for Blink in 1.4+

@skyline75489 skyline75489 mentioned this issue Feb 10, 2021
Merged
ghost pushed a commit that referenced this issue Feb 18, 2021
@skyline75489
Introduce DxFontRenderData (#9096)
eb34993 
This is my attempt to isolate all the dwrite font related thing by
introducing a new layer - `DxFontRenderData`. This will free
`DxRenderer` & `CustomTextLayout` from the burden of handling fonts &
box effects. The logic is more simplified & streamlined.

In short I just moved everything fonts-related into `DxFontRenderData`
and started from there. There's no modification to code logic. Just pure
structural stuff.

SGR support tracking issue: #6879
Initial Italic support PR: #8580
@zadjii-msft zadjii-msft mentioned this issue Mar 26, 2021
Open
1 task
@skyline75489 skyline75489 mentioned this issue Jun 23, 2021
Merged
ghost pushed a commit that referenced this issue Jul 7, 2021
@skyline75489
Render SGR 1 ("intensity") as bold in the DX engine (#10498)
a507311 
This commit adds support for bold text in DxRenderer.

For now, bold fonts are always rendered using DWRITE_FONT_WEIGHT_BOLD
regardless of the base weight.

As yet, this behavior is unconfigurable.

References
Previous refactoring PRs: #9096 (DxFontRenderData) #9201 (DxFontInfo) 
SGR support tracking issue: #6879

Closes #109
@skyline75489
Copy link
Collaborator

Huh, IIRC Italic is already supported since #8580, right? And of course, bold doesn't break Italic. My refactoring PRs were designed to support both features.

@zadjii-msft zadjii-msft mentioned this issue Jun 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-VT Virtual Terminal sequence support Issue-Scenario Product-Conhost For issues in the Console codebase Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Megathreads
Development

No branches or pull requests
6 participants
@rbanffy @DHowett @skyline75489 @zadjii-msft @jdebp @Nosamdaman