Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The rounded bottom corner on a tab doesn't get colored by the color picker #7133

Closed
zadjii-msft opened this issue Jul 31, 2020 · 4 comments · Fixed by microsoft/microsoft-ui-xaml#5145 or #11240
Closed

The rounded bottom corner on a tab doesn't get colored by the color picker #7133

zadjii-msft opened this issue Jul 31, 2020 · 4 comments · Fixed by microsoft/microsoft-ui-xaml#5145 or #11240
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented Jul 31, 2020 •
edited
Loading

image

enhance.gif:
image

Probably regressed when we ingested the latest MUX that included the rounded corners. I'm hoping that we don't need to get this updated in MUX itself, and we can just set some other key on the TabViewItem ourselves.
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels Jul 31, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Jul 31, 2020
@DHowett
Copy link
Member

DHowett commented Jul 31, 2020

One more reason to ask MUX to add tab item backrounds for us. 😄

@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 31, 2020
@mdtauk
Copy link

mdtauk commented Jul 31, 2020

Is there not a "light weight" style you can override?

@DHowett
Copy link
Member

DHowett commented Jul 31, 2020

No. TabView was not designed with this use case in mind.

@zadjii-msft zadjii-msft mentioned this issue Aug 26, 2020
Closed
@zadjii-msft zadjii-msft mentioned this issue May 12, 2021
Closed
This was referenced May 28, 2021
Closed
Merged
This was referenced Sep 13, 2021
Merged
Closed
Merged
@ghost ghost added the In-PR This issue has a related PR label Sep 15, 2021
@ghost ghost closed this as completed in #11240 Sep 20, 2021
ghost pushed a commit that referenced this issue Sep 20, 2021
@zadjii-msft
Update to MUX 2.7 (#11240)
cfe14e8 
* this is the same thing as #10996, but with the fix that caused us to #11031  
* This includes microsoft/microsoft-ui-xaml#3769, so we had to make some adjustments to how we handle tab colors. It works the same as before.
* Should enable #11231 to be started
* [x] Closes #10508
* [x] Closes #7133
* [x] Closes #8948
* [ ] I need to finish letting my 19H1 VM boot to make sure unpackaged still works
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 20, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11240, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Make tab corner overlays update colors
Update to MUX 2.7 microsoft/terminal
3 participants
@DHowett @mdtauk @zadjii-msft