Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to bind "applications" key #7144

Closed
simonratner opened this issue Aug 1, 2020 · 3 comments · Fixed by #7328
Closed

Ability to bind "applications" key #7144

simonratner opened this issue Aug 1, 2020 · 3 comments · Fixed by #7328
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@simonratner
Copy link

simonratner commented Aug 1, 2020 •
edited
Loading

Description of the new feature/enhancement

Ability to create key bindings for the "applications" (a.k.a. "menu") key found on many modern keyboards.

Proposed technical implementation details (optional)

Add a new recognised key app, allowing the following:

{ "command": "openNewTabDropdown", "keys": "app" }
@simonratner simonratner added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 1, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 1, 2020
@zadjii-msft
Copy link
Member

If this key is just VK_APPS, that should be fairly trivial

Constant/value Description
VK_APPS 0x5D Applications key (Natural keyboard)

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Aug 3, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 3, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 3, 2020
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 3, 2020
@MichelleTanPY MichelleTanPY mentioned this issue Aug 18, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Aug 18, 2020
@ghost ghost closed this as completed in #7328 Aug 18, 2020
@ghost ghost removed the In-PR This issue has a related PR label Aug 18, 2020
ghost pushed a commit that referenced this issue Aug 18, 2020
@MichelleTanPY
Add menu (also known as "app") as a bindable key (#7328)
93d2669 
- Add MENU key with "menu" "app" as key bindings.
- Updated profiles.schema.json and documentation.

## Validation Steps Performed
Ran tests locally.
Tested out the new key binding.
```{ "command": "openNewTabDropdown", "keys": "app" }```

Closes #7144
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Aug 18, 2020
DHowett pushed a commit that referenced this issue Aug 24, 2020
@MichelleTanPY @DHowett
Add menu (also known as "app") as a bindable key (#7328)
bc62dbb 
- Add MENU key with "menu" "app" as key bindings.
- Updated profiles.schema.json and documentation.

## Validation Steps Performed
Ran tests locally.
Tested out the new key binding.
```{ "command": "openNewTabDropdown", "keys": "app" }```

Closes #7144

(cherry picked from commit 93d2669)
@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7328, which has now been successfully released as Windows Terminal v1.2.2381.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Aug 26, 2020

🎉This issue was addressed in #7328, which has now been successfully released as Windows Terminal Preview v1.3.2382.0.:tada:

Handy links:

@jtnord jtnord mentioned this issue Nov 4, 2020
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Add menu (also known as "app") as a bindable key MichelleTanPY/terminal
3 participants
@DHowett @simonratner @zadjii-msft