Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide realtime commandline parsing feedback in the commandline mode of the command palette #7284

Closed
zadjii-msft opened this issue Aug 13, 2020 · 1 comment · Fixed by #8515
Closed

Provide realtime commandline parsing feedback in the commandline mode of the command palette #7284

zadjii-msft opened this issue Aug 13, 2020 · 1 comment · Fixed by #8515
Labels
Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal Backlog

Comments

@zadjii-msft
Copy link
Member

Follow up to: Command Palette: Add support for commandline mode #6677

Something that looks like:
image

but like, with the error message from parsing it.

We've gotta move the ThrottledFunc from TerminalControl up to the WinRTUtils so TerminalApp can use it to debounce filter text changed events.

            <StackPanel
                Padding="16"
                Visibility="Visible"
                Grid.Row="3">
                <TextBlock
                    Foreground="Red"
                    x:Name="_commandlineErrorText"
                    Text="Failed to parse commandline. Error was:">
                </TextBlock>
                <TextBlock
                    Padding="16, 0, 0, 0"
                    x:Name="_commandlineErrorText"
                    Text="Foo is not a commandline">
                </TextBlock>
            </StackPanel>
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Aug 13, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Aug 13, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Aug 14, 2020
Merged
4 tasks
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Aug 15, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 1, 2020
Open
52 tasks
@zadjii-msft zadjii-msft mentioned this issue Nov 20, 2020
Closed
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@Don-Vito Don-Vito mentioned this issue Dec 10, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Dec 16, 2020
@ghost ghost closed this as completed in #8515 Dec 16, 2020
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Dec 16, 2020
ghost pushed a commit that referenced this issue Dec 16, 2020
@Don-Vito
Introduce parsed command line text to command palette (#8515)
22d43a4 
This commit introduces another optional text block in palette that will
be shown in the command line mode (above the history). This text block
will either contain a list of parsed command lines or a description why
the parsing failed

Closes #8344
Closes #7284
@ghost
Copy link

ghost commented Jan 28, 2021

🎉This issue was addressed in #8515, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.:tada:

Handy links:

mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@Don-Vito @mpela81
Introduce parsed command line text to command palette (microsoft#8515)
395d29c 
This commit introduces another optional text block in palette that will
be shown in the command line mode (above the history). This text block
will either contain a list of parsed command lines or a description why
the parsing failed

Closes microsoft#8344
Closes microsoft#7284
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal Backlog
Development

Successfully merging a pull request may close this issue.

Introduce parsed command line text to command palette Don-Vito/terminal
2 participants
@DHowett @zadjii-msft