When selecting a new tab with the tab switcher, preview the selected tab in the Terminal #7409
Assignees
Labels
Area-User Interface
Issues pertaining to the user interface of the Console or Terminal
Issue-Task
It's a feature request, but it doesn't really need a major design.
Priority-1
A description (P1)
Product-Terminal
The new Windows Terminal.
Resolution-Fix-Committed
Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Comments
zadjii-msft
added
Area-User Interface
ghost
added
the
Needs-Triage
|
One of the reasons I switched back to the old switching behaviour is because I often have 5+ tabs open with the same name, and selecting a tab without actually seeing what is on it is hard. |
zadjii-msft
removed
the
Needs-Triage
|
The lack of this feature is the main reason I disabled the tab switcher. I really like the switcher, but I like the previous behavior of seeing the content during "tabbing" better. |
zadjii-msft
added
Priority-1
3 tasks
ghost
added
Resolution-Fix-Committed
ghost
pushed a commit
that referenced
this issue
Oct 7, 2020
## Summary of the Pull Request  This PR enables the ATS to display the active tab as the user navigates the tab switcher. We do this by dispatching the tab switch actions as the user navigates the menu, and manually _not_ focusing the new tab when the tab switcher is open. ## References * #6732 - original tab switcher PR * #6689 - That's a more involved, generic version of this, but this PR will be enough to stop most of the complaints hopefully ## PR Checklist * [x] Closes #7409 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Opened tabs, tabbed through the menu, verified that it did what I'd expect
DHowett
pushed a commit
that referenced
this issue
Oct 19, 2020
## Summary of the Pull Request  This PR enables the ATS to display the active tab as the user navigates the tab switcher. We do this by dispatching the tab switch actions as the user navigates the menu, and manually _not_ focusing the new tab when the tab switcher is open. ## References * #6732 - original tab switcher PR * #6689 - That's a more involved, generic version of this, but this PR will be enough to stop most of the complaints hopefully ## PR Checklist * [x] Closes #7409 * [x] I work here * [ ] Tests added/passed * [n/a] Requires documentation to be updated ## Validation Steps Performed Opened tabs, tabbed through the menu, verified that it did what I'd expect (cherry picked from commit 22887d7)
This was referenced Oct 22, 2020
|
🎉This issue was addressed in #7796, which has now been successfully released as Handy links: |
|
🎉This issue was addressed in #7796, which has now been successfully released as Handy links: |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The new tab switcher is great. But I think it'd be even cooler if as I was switching tabs with it, the content of the terminal changed to reflect the tab I had selected.
So if I had [cmd, ubuntu, pwsh] open, with cmd focused, and opened the tab switcher to the "next tab", then the terminal would show me the ubuntu tab underneath the tab switcher. If I hit next tab again, then I want to see powershell underneath the switcher. Then, if I release the anchor key, just close the tab switcher. If I hit escape instead, then return me back to the tab I started on (cmd).
This is kinda a specialization of "Allow commands to be previewed in the command palette #6689", but this might be easier to do with the tab switcher, considering we already know that the original tab was (the state to restore to), and the command to use as the "preview".
I tried trivially implementing this today, but as I dispatched the commands from the cmdpal, the focus moved out of the cmdpal into the terminal, so that might be something to watch out for.
/cc @leonMSFT
The text was updated successfully, but these errors were encountered: