Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyperlinks: Please allow "file" schema #7699

Closed
daniel-liuzzi opened this issue Sep 22, 2020 · 5 comments · Fixed by #7526
Closed

Hyperlinks: Please allow "file" schema #7699

daniel-liuzzi opened this issue Sep 22, 2020 · 5 comments · Fixed by #7526
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@daniel-liuzzi
Copy link

Description of the new feature/enhancement

At the moment, hyperlink support seems limited to just http and https schemas. It would be nice if file was supported as well.

A sample use case for this is https://github.com/dandavison/delta, an excellent viewer for git and diff output that, among other things, shows line numbers in a git diff as links pointing to the given file. This currently doesn't work due to Windows Terminal blocking the file schema:

image
@daniel-liuzzi daniel-liuzzi added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 22, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 22, 2020
@daniel-liuzzi daniel-liuzzi mentioned this issue Sep 22, 2020
Closed
@DHowett
Copy link
Member

DHowett commented Sep 22, 2020

/dup #7526

@ghost
Copy link

ghost commented Sep 22, 2020

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Sep 22, 2020
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 22, 2020
@DHowett
Copy link
Member

DHowett commented Sep 22, 2020

I hate duping things to PRs, but this one has some active discussion on it.

We were having a long discussion over on #7526 about it, and never came to anywhere we felt comfortable with. The same discussion is playing out in #7668, because of how hard it is for the Terminal alone to map paths...

@DHowett
Copy link
Member

DHowett commented Sep 22, 2020 •
edited
Loading

On second thought, I'll reopen this bug as a landing site to redirect folks / point the PR at.

@DHowett DHowett reopened this Sep 22, 2020
@DHowett DHowett removed the Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. label Sep 22, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 22, 2020
@DHowett DHowett added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Sep 22, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 22, 2020
@DHowett DHowett added this to the Terminal v1.5 milestone Sep 22, 2020
@DHowett DHowett mentioned this issue Sep 22, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Sep 22, 2020
@j4james j4james mentioned this issue Jan 31, 2021
Closed
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Feb 19, 2021
DHowett pushed a commit that referenced this issue Feb 19, 2021
@PankajBhojwani
Support the "file" URI scheme (#7526)
dfeb855 
We now support the file URI schemes where the hostname is either
"localhost" or the empty string

References #5001

Fixes #7699
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 19, 2021
@ghost
Copy link

ghost commented Mar 1, 2021

🎉This issue was addressed in #7526, which has now been successfully released as Windows Terminal Preview v1.7.572.0.:tada:

Handy links:

@Jelleas Jelleas mentioned this issue Sep 20, 2022
Merged
@ltrzesniewski ltrzesniewski mentioned this issue Oct 2, 2022
Open
@nathanpovo nathanpovo mentioned this issue Jul 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Support the "file" URI scheme microsoft/terminal
4 participants
@daniel-liuzzi @DHowett @zadjii-msft @cinnamon-msft