Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Screen Reader-Command Palette]-Screen reader user will not be able to identify the purpose of New Tab control if role and state are not appropriate. #7908

Closed
DasaradhaKamjula opened this issue Oct 13, 2020 · 4 comments
Closed

[Screen Reader-Command Palette]-Screen reader user will not be able to identify the purpose of New Tab control if role and state are not appropriate. #7908

DasaradhaKamjula opened this issue Oct 13, 2020 · 4 comments
Labels
A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v2.0

Comments

@DasaradhaKamjula
Copy link
Collaborator

DasaradhaKamjula commented Oct 13, 2020 •
edited
Loading

User Experience:
Users who rely on screen reader will not be able to get the info of sub menu if role/state is not provided properly

Test Environment:
App: Windows Terminal Preview
Feature: Command Palette
Screen Reader: Narrator
OS: Win 10 2004 Build (19041.508)

Repro Steps:
1.Open Windows terminal Preview app
2.Open Command Palette using shortcut (Ctrl+shift+p)
3.Search for New tab command in the search field
4.Navigate to New Tab list item having sub menu and Observe whether screen reader is providing proper info or not

Actual:
Screen reader user will not be able to identify the purpose of New Tab control if role and state are not appropriate. Screen reader announces the name and position only and also Multiple New tab list items are present in the list and the announcement is same which will confuse user.

Note: Same issue repro for Split pane and Set color scheme controls having Sub menu

Expected:
State should announce state as Collapsed or it should provide extra role description like "Has pop Up" which helps in differentiating the New tab list items and also the purpose of New tab having sub menu.

MAS Reference:
https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={248054a6-5e68-4771-9e1e-242fb5025730}
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Oct 13, 2020
@zadjii-msft zadjii-msft added Area-Accessibility Issues related to accessibility Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Impact-Compliance It gotta be this way. labels Oct 13, 2020
@zadjii-msft zadjii-msft mentioned this issue Oct 13, 2020
Open
52 tasks
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Oct 15, 2020
@DHowett DHowett added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 16, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Oct 16, 2020
@cinnamon-msft cinnamon-msft added the HCL-E+D Accessibility tracking label Oct 20, 2020
@zadjii-msft zadjii-msft added the Area-CmdPal Command Palette issues and features label Dec 1, 2020
@Chandresh1007 Chandresh1007 added A11yWCAG Accessibility tracking HCL-WindowsConsole Accessibility tracking HCL-WindowsTerminal Accessibility tracking labels Dec 7, 2020
@DHowett DHowett mentioned this issue Feb 23, 2021
Closed
@carlos-zamora carlos-zamora mentioned this issue Feb 24, 2021
Merged
1 task
DHowett pushed a commit that referenced this issue Feb 24, 2021
@carlos-zamora
[v1.6] Add help text to 'more options' in command palette (#9262)
83d35c1 
This adds help text (automation property) to command palette commands that expand to more options.

Addresses #7908

## Validation Steps Performed
If I have a nested command called "color tab", NVDA reads it as...
"Color tab. More options. 5 of 79."
@DHowett DHowett added the Fixed Issues assigned by the accessibility team that have been fixed. label Feb 24, 2021
@DHowett
Copy link
Member

DHowett commented Feb 24, 2021

This fix will be deployed to the Stable channel tomorrow (Thursday).

@carlos-zamora carlos-zamora mentioned this issue Feb 24, 2021
Merged
1 task
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels Feb 24, 2021
DHowett pushed a commit that referenced this issue Feb 24, 2021
@carlos-zamora
Add help text to 'more options' in command palette (#9271)
d1bf0fc 
Similar to #9262. This creates another data template specifically for
command palette items that open up more options. We leverage the
localization key from #9262 to apply help text to this template
automatically.

Using the data template approach, we now have no need for the
`HasNestedComandsVisibilityConverter`, so that set of files is now
deleted. The logic to detect nested commands was moved to the template
selector.

## Validation Steps Performed
Tested using NVDA.

Addresses #7908 better
DHowett pushed a commit that referenced this issue Feb 24, 2021
@carlos-zamora @DHowett
Add help text to 'more options' in command palette (#9271)
28c7890 
Similar to #9262. This creates another data template specifically for
command palette items that open up more options. We leverage the
localization key from #9262 to apply help text to this template
automatically.

Using the data template approach, we now have no need for the
`HasNestedComandsVisibilityConverter`, so that set of files is now
deleted. The logic to detect nested commands was moved to the template
selector.

## Validation Steps Performed
Tested using NVDA.

Addresses #7908 better

(cherry picked from commit d1bf0fc)
@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11ySev3 Accessibility tracking label Jun 10, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 removed the HCL-WindowsConsole Accessibility tracking label Jul 21, 2021
@zadjii-msft
Copy link
Member

@Chandresh1007, @DasaradhaKamjula, @Priyanka-Chauhan123 - can you confirm that this is fixed, and close it if it is? This should have shipped in 1.6. Thanks!

@Priyanka-Chauhan123
Copy link
Collaborator

Issue is fixed. Verified on below environment.
Windows Terminal App version: 1.9.1942.0.
OS: Windows 10 build 21390.2025.
Hence, closing the bug.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Aug 11, 2021
@Priyanka-Chauhan123 Priyanka-Chauhan123 added the A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. label Jan 9, 2024
@Priyanka-Chauhan123
Copy link
Collaborator

Closing the bug as issue has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11ySev3 Accessibility tracking A11yTTValidated Yet another label for the a11y folks. They want so many. So so many. A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility Area-CmdPal Command Palette issues and features Area-User Interface Issues pertaining to the user interface of the Console or Terminal Fixed Issues assigned by the accessibility team that have been fixed. HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking Impact-Compliance It gotta be this way. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v2.0
Development

No branches or pull requests
6 participants
@DHowett @zadjii-msft @DasaradhaKamjula @cinnamon-msft @Chandresh1007 @Priyanka-Chauhan123