Impossible to set custom tab color after setting it to black

[ItsMeSousuke]

Environment

Windows build number: Win32NT, 10.0.18362.0 Microsoft Windows NT 10.0.18362.0
Windows Terminal version (if applicable): 1.3.2651.0

Steps to reproduce

1. Right click on tab and select Color...
2. Click Custom
3. Click More
4. Remove value from hex code field, tab background is set to black
5. Try to pick any color from color picker

Expected behavior

User should be able to pick new color from color picker.

Actual behavior

Tab color is black and can't be change by picking color from color picker, it can be only change by selecting one from predefined list or by setting any other color hex code other than black

[ghost]

I can repro it:

[ghost]

I think this is an issue with the XAML ColorPicker control. Because I was able to reproduce this issue in XAML Controls Gallery

And a little more closer look:

[ghost]

This is what I think is the reason why this is not working

Look at the slider. It is set to black. So if you change the color using that rainbow like thing, that slider is still at black.
You have to move the slider in order for it to work (and I have confirmed it).

This also explains why the color changes successfully when you choose a preset color or you give another hex value.

The funny thing is that Windows Terminal does not have this slider

This is probably because

The one with the slider:

The one that Windows Terminal be likely be using:

[ghost]

cc @DHowett @zadjii-msft

[ghost]

GIFing this problem:

(Sorry for my extremely bad GIFs. Especially the ColorPicker control 🤢)

The problem:

Demonstrating the problem and a possible fix in XAML Studio:

I think we can fix this by enabling Color Slider in the ColorPicker control.

I would like to make a PR on this if you agree on this fix (only if this fix is going to be as easy as I did in XAML Studio)

[WSLUser]

Is there an existing issue in https://github.com/microsoft/microsoft-ui-xaml/issues? This seems like a good workaround to add but ultimately this is a bug with the XAML framework and should be addressed by the WINUI team.

[zadjii-msft]

Yea, I think it's fine to fix locally for the Terminal with enabling the color slider, but I agree, we should file a follow-up on the WinUI repo that WSLUser linked.

[ghost]

@zadjii-msft I will take up this issue

[ghost]

@zadjii-msft
Just point me to the right XAML file.

[zadjii-msft]

https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/ColorPickupFlyout.xaml

[ghost]

@zadjii-msft

PR ready to be reviewed -> #7963

[WSLUser]

So I did check and there isn't an existing issue on the WinUI repo. Please create a ticket and link to it here. The PR should be considered a workaround, not a "fix" and so this issue should be closed when we pick up a version of MUX with the fix. We should add the upstream-issue and workaround-available tags for tracking/visibility.

[zadjii-msft]

I've filed microsoft/microsoft-ui-xaml#3476 upstream, but I'm okay leaving this issue closed, because frankly, the picker is better off with the color slider visible. That makes it possible to pick both a lightness and a hue, which greatly increases the range of easily accessible tab colors.

Thanks for the investigation @alannt777!

[ghost]

🎉This issue was addressed in #7963, which has now been successfully released as Windows Terminal v1.4.3141.0.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #7963, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.:tada:

Handy links:

• Release Notes
• Store Download