Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Echo: Predict the display of remote characters #8178

Open
MarnoRossouwX opened this issue Nov 6, 2020 · 4 comments
Open

Local Echo: Predict the display of remote characters #8178

MarnoRossouwX opened this issue Nov 6, 2020 · 4 comments
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone

Comments

@MarnoRossouwX
Copy link

Description of the new feature/enhancement

Predict characters that will be displayed in the terminal without having to wait for the shell. This is done in the 1.51 release of Visual Studio Code and is explained in detail on its release notes: https://code.visualstudio.com/updates/v1_51#_local-echo

As explained in the Visual Studio Code release notes, this will be particularly useful when working over an ssh connection.

Proposed technical implementation details (optional)

@MarnoRossouwX MarnoRossouwX added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Nov 6, 2020
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 6, 2020
@zadjii-msft
Copy link
Member

Well that's certainly an interesting idea. There's a little more discussion here. Specifically that calls out not doing this in the alt buffer, which I think is a reasobaly assumption.

From purely an implementation standpoint, I wonder if there's an easy way to do this with "overlays" like we had considered years ago for popups. I'm not sure that we'd want to actually populate the buffer with these "predicted" contents, we'd need some way to keep the predictions separate.

@zadjii-msft zadjii-msft added Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Product-Terminal The new Windows Terminal. labels Nov 8, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 8, 2020
@zadjii-msft zadjii-msft added this to the Terminal Backlog milestone Nov 8, 2020
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Nov 12, 2020
@DHowett
Copy link
Member

DHowett commented Dec 4, 2020

This sounds a lot like mosh.

@djsavvy
Copy link

djsavvy commented Dec 7, 2020

Does this really need to be implemented in the terminal itself? I feel like delegating this functionality to mosh makes more sense.

@gakio12
Copy link

gakio12 commented Dec 10, 2020

mosh requires a server component to be installed. The functionality in VSCode does not require a remote component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

No branches or pull requests

5 participants