Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish TabBase #8452

Closed
Tracked by #10000
carlos-zamora opened this issue Dec 1, 2020 · 0 comments · Fixed by #16172
Closed
Tracked by #10000

Polish TabBase #8452

carlos-zamora opened this issue Dec 1, 2020 · 0 comments · Fixed by #16172
Assignees
@zadjii-msft
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@carlos-zamora
Copy link
Member

carlos-zamora commented Dec 1, 2020 •
edited
Loading

TerminalPage::_RefreshUIForSettingsReload() has a section where it iterates through each tab and updates the settings in one way or another. This can be slightly refactored by...

  • add UpdateSettings to TabBase
  • have the for-loop just call UpdateSettings on each one
  • unify creating a new terminal tab and settings tab

Additional refactor work items can/will be added here as they come up.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels Dec 1, 2020
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 1, 2020
@carlos-zamora carlos-zamora mentioned this issue Dec 1, 2020
Merged
This was referenced Dec 9, 2020
Merged
Open
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 15, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Dec 15, 2020
@DHowett DHowett added the Area-User Interface Issues pertaining to the user interface of the Console or Terminal label Dec 15, 2020
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@carlos-zamora carlos-zamora mentioned this issue Jun 27, 2022
Open
65 tasks
@zadjii-msft zadjii-msft self-assigned this Aug 23, 2023
@zadjii-msft zadjii-msft mentioned this issue Mar 27, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Mar 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 3, 2024
@zadjii-msft
Refactor the SettingsTab to be a pane (#16172)
67ae9f6 
... technically. We still won't let it actually _be_ a pane, but now it
acts like one. It's hosted in a `SettingsPaneContent`. There's no more
`SettingsTab`. It totally _can_ be in a pane (but don't?)

## Validation Steps Performed

* Still opens the settings
* Only opens a single settings tab, or re-activates the existing one
* Session restores!
* Updates the title of the tab appropriately
* I previously _did_ use the scratchpad action to open the settings in a
pane, and that worked.

## Related PRs
* #16170
  * #16171 
    * #16172 <-- you are here 
      * #16895

Refs #997
Closes #8452
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Refactor the SettingsTab to be a pane microsoft/terminal
3 participants
@DHowett @carlos-zamora @zadjii-msft