Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display "find" matches in the scrollbar #8631

Closed
rkeithhill opened this issue Dec 21, 2020 · 5 comments · Fixed by #14045
Closed

Display "find" matches in the scrollbar #8631

rkeithhill opened this issue Dec 21, 2020 · 5 comments · Fixed by #14045
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@rkeithhill
Copy link
Contributor

rkeithhill commented Dec 21, 2020 •
edited
Loading

Description of the new feature/enhancement

VSCode has this nice feature where find "matches" are displayed by a certain color (brown here) in the scrollbar e.g.:

image

This instantly lets the user know where in the overall file the matches are. IMO this is even more useful in a console with a large scrollback buffer (10000 lines). The example above also shows a mini-map to the left of the scrollbar that also shows matches but I think that would cut into the console too much.

Proposed technical implementation details (optional)

First, while the find dialog is open, ensure the entire scrollbar is visible (not just the little sliver that shows when you're not hovering over the scrollbar). Second, for every match, display a horizontal line of a discernable color that corresponds to each match location in the scrollback buffer.
@rkeithhill rkeithhill added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 21, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Dec 21, 2020
@skyline75489
Copy link
Collaborator

#3920 might has some of the feature included.

@zadjii-msft
Copy link
Member

I'm gonna narrow this down to just the scrollbar highlighting, since #6319 is already tracking the "number of matches". Thanks!

@zadjii-msft zadjii-msft changed the title It would help users know how many matches & where they are if find displayed matches in the scrollbar Display "find" matches in the scrollbar Dec 21, 2020
@zadjii-msft zadjii-msft added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Dec 21, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Dec 21, 2020
@zadjii-msft zadjii-msft mentioned this issue Dec 21, 2020
Open
20 tasks
@j4james
Copy link
Collaborator

j4james commented Dec 21, 2020

See also #1527 and #2226, which cover similar issues.

@DHowett
Copy link
Member

DHowett commented Jan 28, 2021

Actually, yeah, I'm inclined to call this a /dupe of #1527. Thanks for digging, James!

@ghost
Copy link

ghost commented Jan 28, 2021

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost ghost closed this as completed Jan 28, 2021
@ghost ghost added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 28, 2021
@zadjii-msft zadjii-msft removed this from the Terminal Backlog milestone Jan 28, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 20, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Sep 20, 2022
zadjii-msft added a commit that referenced this issue Sep 5, 2023
@zadjii-msft @Don-Vito
Show number of search results & positions of hits in scrollbar (#14045)
0cbde94 
This is a resurrection of #8588. That PR became painfully stale after
the `ControlCore` split. Original description:

> ## Summary of the Pull Request
> This is a PoC for:
> * Search status in SearchBox (aka number of matches + index of the
current match)
> * Live search (aka search upon typing)
> ## Detailed Description of the Pull Request / Additional comments
> * Introduced this optionally (global setting to enable it)
> * The approach is following:
>   * Every time the filter changes, enumerate all matches
>   * Upon navigation just take the relevant match and select it
> 

I cleaned it up a bit, and added support for also displaying the
positions of the matches in the scrollbar (if `showMarksOnScrollbar` is
also turned on).

It's also been made SUBSTANTIALLY easier after #15858 was merged.

Similar to before, searching while there's piles of output running isn't
_perfect_. But it's pretty awful currently, so that's not the end of the
world.

Gifs below.

* closes #8631 (which is a bullet point in #3920)
* closes #6319


Co-authored-by: Don-Vito <khvitaly@gmail.com>

---------

Co-authored-by: khvitaly <khvitaly@gmail.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show number of search results & positions of hits in scrollbar microsoft/terminal
5 participants
@DHowett @j4james @skyline75489 @rkeithhill @zadjii-msft