Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings UI should hide all warning settings #8757

Closed
carlos-zamora opened this issue Jan 12, 2021 · 1 comment · Fixed by #8779
Closed

Settings UI should hide all warning settings #8757

carlos-zamora opened this issue Jan 12, 2021 · 1 comment · Fixed by #8779
Assignees
@PankajBhojwani
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.6

Comments

@carlos-zamora
Copy link
Member

All warning-related settings should be removed from the Settings UI (at least for now). This includes:

  • Appearance > Show close all tabs popup

The introduction of #8324 will create a much cleaner story for warnings in Windows Terminal. After #8324, we should probably introduce a button to "reset all warnings" or something like that, but the game plan for now is...
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Area-Settings UI Anything specific to the SUI labels Jan 12, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.6 milestone Jan 12, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@carlos-zamora
Copy link
Member Author

Assigned Pri-1 because if we keep this setting and remove it later, I feel like we might get a little bit of confusion in the community?

@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 12, 2021
@PankajBhojwani PankajBhojwani mentioned this issue Jan 13, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Jan 13, 2021
@PankajBhojwani PankajBhojwani self-assigned this Jan 13, 2021
@ghost ghost closed this as completed in #8779 Jan 14, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 14, 2021
ghost pushed a commit that referenced this issue Jan 14, 2021
@PankajBhojwani
Remove setting for close all tabs pop up (#8779)
e851c61 
Remove the setting for enabling/disabling the dialog that
shows up to confirm the closing of all tabs in the SUI

Closes #8757
mpela81 pushed a commit to mpela81/terminal that referenced this issue Jan 28, 2021
@PankajBhojwani @mpela81
Remove setting for close all tabs pop up (microsoft#8779)
aeff4e6 
Remove the setting for enabling/disabling the dialog that
shows up to confirm the closing of all tabs in the SUI

Closes microsoft#8757
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PankajBhojwani PankajBhojwani

Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.6
Development

Successfully merging a pull request may close this issue.

Remove setting for close all tabs pop up microsoft/terminal
2 participants
@carlos-zamora @PankajBhojwani