Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid double-negatives in Settings UI #8900

Closed
carlos-zamora opened this issue Jan 26, 2021 · 0 comments · Fixed by #9124
Closed

Avoid double-negatives in Settings UI #8900

carlos-zamora opened this issue Jan 26, 2021 · 0 comments · Fixed by #9124
Assignees
@carlos-zamora
Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.7

Comments

@carlos-zamora
Copy link
Member

PaneAnimations

There's a double negative for "Disable pane animations". It should probably be something like this instead:

Animate panes
[*] On

Assigning @cinnamon-msft for design

We'll probably need to introduce some kind of InvertedBooleanConverter (or maybe handle it in the ProfileViewModel?). Should be easy to do.
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-Settings UI Anything specific to the SUI labels Jan 26, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 26, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.7 milestone Jan 26, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 26, 2021
@carlos-zamora carlos-zamora mentioned this issue Feb 11, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Feb 11, 2021
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Feb 19, 2021
DHowett pushed a commit that referenced this issue Feb 19, 2021
@carlos-zamora
Polish settings UI localized text (#9124)
1774302 
Updates the following text in the settings UI
- focus follow mouse mode is introduced to be more instructional
- focus follow mouse mode tooltip removed
- avoid double negative in "disable pane animation"

Closes #8900 
Updates #6459 Settings UI text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings UI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.7
Development

Successfully merging a pull request may close this issue.

Polish settings UI localized text microsoft/terminal
3 participants
@DHowett @carlos-zamora @cinnamon-msft