Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] An option to disable colour font emoji #956

Closed
Tracked by #1790
zadjii-msft opened this issue May 23, 2019 · 4 comments · Fixed by #16871
Closed
Tracked by #1790

[Settings] An option to disable colour font emoji #956

zadjii-msft opened this issue May 23, 2019 · 4 comments · Fixed by #16871
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

Is there any merit to having an option to disable colour font emoji?

So any emoji used will be single colour using the font colour settings?

Originally posted by @mdtauk in #190 (comment)

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 23, 2019
@zadjii-msft zadjii-msft added Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels May 23, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 23, 2019
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label May 23, 2019
@DHowett-MSFT DHowett-MSFT removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 23, 2019
@DHowett-MSFT
Copy link
Contributor

There's some discussion about getting options into the renderer in #817.

@DHowett
Copy link
Member

DHowett commented Jun 26, 2020

From @francogp

Environment

Windows build number: Win32NT 10.0.19041.0 Microsoft Windows NT 10.0.19041.0
Windows Terminal version (if applicable): 1.0.1402.0

Using WSL Ubuntu LTS version 20.04

I'm using this font, but can reproduced with others too: JetBrainsMono

Expected behavior

image taken by using other windows terminal emulators, like Terminus on windows, and Tilix or Terminator on Ubuntu. All the same results
image

Actual behavior

image
Lots of characters/emoticons have a wrong size at render. This is just an example. Look up the check emoticon ✔
It seems that its ignoring my font.

I believe DirectWrite prefers a color glyph for this.

I wonder if we should like to add emoji "range" settings for fine-grained control of this. Maybe I want to disable emoji WHITE SMILING FACE only?

@zadjii-msft
Copy link
Member Author

Curious if this is a font feature that we added by happenstance back in #10433

@alexrsagen
Copy link

Is there any merit to having an option to disable colour font emoji?

Yes! For example, some CLI libraries may use colored text emojis in order to display a "selected" (green) / "not selected" (gray) state in a multi-select list.

For applications using such CLI approaches to work, it is important to be able to prefer text emoji over colored emoji.

@github-project-automation github-project-automation bot moved this from Should be written to Done in Terminal Walkthroughs Mar 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Rendering Text rendering, emoji, complex glyph & font-fallback issues Area-Settings Issues related to settings and customizability, for console or terminal Help Wanted We encourage anyone to jump in on these. In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants