Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress state doesn't update correctly between panes #9743

Closed
Tracked by #6700
zadjii-msft opened this issue Apr 7, 2021 · 4 comments · Fixed by #9779
Closed
Tracked by #6700

Progress state doesn't update correctly between panes #9743

zadjii-msft opened this issue Apr 7, 2021 · 4 comments · Fixed by #9779
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

  1. Set the progress to indeterminate state in a pane.
  2. Open a new tab. Note that the taskbar and tabs display as expected.
  3. Switch back to the first tab. Note that the taskbar and tabs display as expected.
  4. Open a new pane. Note that the tab and taskbar still display the progress state!
  5. Switch to the second tab. Note that the taskbar and tabs display as expected.
  6. Switch back to the first tab. Note that the taskbar and tabs display as expected. (no progress, because the second pane does not have progress state)
  7. Switch to the first pane. Note that the tab and taskbar still have no progress state!

Seemingly the progress state doesn't update when the active pane changes, only when the active tab does.

I might have a fix for this that's paired with #6842, but do we want to bite off a 30 file PR just for this fix?
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 7, 2021
@zadjii-msft zadjii-msft mentioned this issue Apr 7, 2021
Closed
@DHowett
Copy link
Member

DHowett commented Apr 7, 2021

do we want to bite off

Well, not exactly, but one takes the fix out of the 30 file PR ;)

@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Apr 7, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 7, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Apr 7, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 7, 2021
zadjii-msft added a commit that referenced this issue Apr 8, 2021
@zadjii-msft
This fixes #9743, but I think I'm still doing something off the UI th…
d8beada 
…read
@Don-Vito
Copy link
Contributor

Don-Vito commented Apr 12, 2021 •
edited
Loading

I guess I don't fully understand the logic, but I am not sure why TaskbarProgressChanged is not called upon pane activation. I will create a draft PR with this :)

@Don-Vito Don-Vito mentioned this issue Apr 12, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label Apr 12, 2021
@ghost ghost closed this as completed in #9779 Apr 12, 2021
ghost pushed a commit that referenced this issue Apr 12, 2021
@Don-Vito
Trigger taskbar progress evaluation upon pane activation (#9779)
ca9e5e0 
Trigger TaskbarProgressChanged every time we switch between active panes
(to update the tab header if required).

Closes #9743
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 12, 2021
DHowett pushed a commit that referenced this issue Apr 12, 2021
@Don-Vito @DHowett
Trigger taskbar progress evaluation upon pane activation (#9779)
17f9dbf 
Trigger TaskbarProgressChanged every time we switch between active panes
(to update the tab header if required).

Closes #9743

(cherry picked from commit ca9e5e0)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9779, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9779, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Apr 20, 2021
Merged
5 tasks
@zadjii-msft zadjii-msft mentioned this issue Jul 13, 2021
Open
4 tasks
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Trigger taskbar progress evaluation upon pane activation Don-Vito/terminal
3 participants
@DHowett @Don-Vito @zadjii-msft