Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shift-click-drag resets selection start point #9787

Closed
1 task
DHowett opened this issue Apr 12, 2021 · 8 comments
Closed
1 task

shift-click-drag resets selection start point #9787

DHowett opened this issue Apr 12, 2021 · 8 comments
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.8

Comments

@DHowett
Copy link
Member

DHowett commented Apr 12, 2021

To add to @Don-Vito's test cases 😄

  • click-drag (set selection), shift-click-drag (extend selection while dragging)

Right now, shift-click-drag resets the start point when the drag happens (but successfully extends when the click happens!)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 12, 2021
@DHowett DHowett added Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Apr 12, 2021
@DHowett
Copy link
Member Author

DHowett commented Apr 12, 2021

Marking P1 for servicing into 1.7, since we've taken all the other selection fixes in there.

Alternatively, I can back out all the selection changes from 1.7 and we'll go back to the thing we shipped in 1.6. It's got some known issues, but at least they're known ones!

@DHowett DHowett added this to the Terminal v1.8 milestone Apr 12, 2021
@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 12, 2021
@Don-Vito
Copy link
Contributor

@DHowett - I will take a look later on today! I really hope we fix all in 1.7 rather than revert.

@Don-Vito
Copy link
Contributor

On it.

@Don-Vito Don-Vito mentioned this issue Apr 12, 2021
Merged
25 tasks
@ghost ghost added In-PR This issue has a related PR Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 12, 2021
@ghost ghost closed this as completed in b8e36ba Apr 12, 2021
DHowett pushed a commit that referenced this issue Apr 13, 2021
@Don-Vito @DHowett
Prevent mouse dragging from dismissing existing selection (#9790)
15028f3 
## PR Checklist
* [x] Closes #9787
* [x] CLA signed.
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.

## Validation Steps Performed
* [x] single click = no selection
* [x] single click and drag = selection starting from first point
* [x] single click in unfocused pane and drag = focus pane, selection starting from first point
* [x] double-click = selects a whole word
* [x] triple-click = selects a whole line
* [x] double-click and drag = selects a whole word, drag selects whole words
* [x] triple-click and drag = selects a whole line, drag selects whole lines
* [x] Shift single-click = defines start point
* [x] second Shift single-click = defines end point
* [x] Shift double-click = selects entire word
* [x] Shift triple-click = selects entire line
* [x] Shift double-click and drag = selects entire word, drag selects whole words
* [x] Mouse mode: Shift single-click = defines start point
* [x] Mouse mode: second Shift single-click = defines end point
* [x] Mouse mode: Shift double-click = selects entire word
* [x] Mouse mode: Shift triple-click = selects entire line
* [x] Mouse mode: Shift double-click and drag = selects entire word, drag selects whole words
* [x] With existing selection: single-click outside the selection and drag = establishes a new selection starting from the click point
* [x] Click-drag to set selection, shift-click-drag outside of selection = extend selection while dragging

(cherry picked from commit b8e36ba)
@YAMLcase
Copy link

Is there an option available to reset selection? Those of us using tmux or vim with mouse support usually use "shift" to disable that app's mouse input so we can select and copy text straight to the Windows clipboard. It is a minor but often frustration that trying to go back and select some more and different text just extends the previous selection. Hitting esc will clear the selection for me, but 99% of the time I forget thus causing the frustration.

@Don-Vito
Copy link
Contributor

@YAMLcase - currently there is no option but ESC. I suggested to allow clearing the selection by shift-click on one of the selection ends (I know that ConEmu does this), but waiting for @DHowett to approve this idea.

@YAMLcase
Copy link

Maybe a round-about way to achieve this behavior would be a 'deselect on copy' option while also having 'copyOnSelect' set to true.

@YAMLcase YAMLcase mentioned this issue Apr 14, 2021
Open
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9790, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9790, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Sep 22, 2021
Closed
@miniksa miniksa removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Sep 27, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.8
Development

No branches or pull requests
4 participants
@DHowett @Don-Vito @miniksa @YAMLcase