remove navigated to

src/cascadia/TerminalSettingsEditor/Appearances.cpp

@@ -109,18 +109,18 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
                     xaml_typename<Editor::Appearances>(),
                     PropertyMetadata{ nullptr });
         }
-    }
 
-    void Appearances::NavigatedTo()
-    {
-        //_ViewModelChangedRevoker = Appearance().PropertyChanged(winrt::auto_revoke, [=](auto&&, const PropertyChangedEventArgs& args) {
-        //    const auto settingName{ args.PropertyName() };
-        //    if (settingName == L"CursorShape")
-        //    {
-        //        _PropertyChangedHandlers(*this, PropertyChangedEventArgs{ L"CurrentCursorShape" });
-        //        _PropertyChangedHandlers(*this, PropertyChangedEventArgs{ L"IsVintageCursor" });
-        //    }
-        //});
+        if (Appearance())
+        {
+            _ViewModelChangedRevoker = Appearance().PropertyChanged(winrt::auto_revoke, [=](auto&&, const PropertyChangedEventArgs& args) {
+                const auto settingName{ args.PropertyName() };
+                if (settingName == L"CursorShape")
+                {
+                    _PropertyChangedHandlers(*this, PropertyChangedEventArgs{ L"CurrentCursorShape" });
+                    _PropertyChangedHandlers(*this, PropertyChangedEventArgs{ L"IsVintageCursor" });
+                }
+            });
+        }
     }
 
     bool Appearances::IsVintageCursor() const

src/cascadia/TerminalSettingsEditor/Appearances.h

@@ -30,8 +30,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
     public:
         Appearances();
 
-        void NavigatedTo();
-
         // CursorShape visibility logic
         bool IsVintageCursor() const;
 

src/cascadia/TerminalSettingsEditor/Appearances.idl

@@ -24,7 +24,6 @@ namespace Microsoft.Terminal.Settings.Editor
     {
         Appearances();
         AppearanceViewModel Appearance;
-        void NavigatedTo();
         static Windows.UI.Xaml.DependencyProperty AppearanceProperty { get; };
 
         IInspectable CurrentCursorShape;

src/cascadia/TerminalSettingsEditor/Profiles.cpp

@@ -87,7 +87,8 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
     ProfileViewModel::ProfileViewModel(const Model::Profile& profile) :
         _profile{ profile },
-        _ShowAllFonts{ false }
+        _ShowAllFonts{ false },
+        _defaultAppearanceViewModel { winrt::make<implementation::AppearanceViewModel>(profile.DefaultAppearance().try_as<AppearanceConfig>()) }
     {
         // Add a property changed handler to our own property changed event.
         // This propagates changes from the settings model to anybody listening to our
@@ -343,7 +344,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
     Editor::AppearanceViewModel ProfileViewModel::DefaultAppearance()
     {
-        return winrt::make<implementation::AppearanceViewModel>(_profile.DefaultAppearance().try_as<AppearanceConfig>());
+        return _defaultAppearanceViewModel;
     }
 
     bool ProfileViewModel::UseDesktopBGImage()
@@ -599,8 +600,6 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
 
         // Navigate to the pivot in the provided navigation state
         ProfilesPivot().SelectedIndex(static_cast<int>(_State.LastActivePivot()));
-
-        DefaultAppearanceXaml().NavigatedTo();
     }
 
     void Profiles::OnNavigatedFrom(const NavigationEventArgs& /*e*/)

src/cascadia/TerminalSettingsEditor/Profiles.h

@@ -103,6 +103,7 @@ namespace winrt::Microsoft::Terminal::Settings::Editor::implementation
         Model::Profile _profile;
         winrt::hstring _lastBgImagePath;
         winrt::hstring _lastStartingDirectoryPath;
+        Editor::AppearanceViewModel _defaultAppearanceViewModel;
         bool _ShowAllFonts;
 
         static Windows::Foundation::Collections::IObservableVector<Editor::Font> _MonospaceFontList;