Commits on May 20, 2021

1. Attempt to heal settings files damaged by #9962 …

   The bug that caused #9962 resulted in folks getting profiles written to
   their settings that didn't contain any identifying information (name or
   guid), sometimes multiple times.
   
   These profiles look (somewhat) like this:
   
   ```json
   { "colorScheme": "Campbell" },
   {},
   ```
   
   An empty profile serves no purpose -- it shows up in the list as being
   named "Default", and it only launches CMD (unless the commandline is the
   thing that the user successfully changed.)
   
   We can heal the settings file by simply ignoring those profiles that
   have *no identifying information* (a guid or a name that can be
   converted into a guid).
   
   Validation
   ----------
   I created a number of profiles that fit this format and made sure that
   they were ignored on load and destroyed on save.

   

   DHowett committed May 20, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for f86d28d
   • Browse repository at this point

   Copy the full SHA

   f86d28d View commit details

   Browse the repository at this point in the history

2. don't do iterators bad

   

   DHowett committed May 20, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for 62553c7
   • Browse repository at this point

   Copy the full SHA

   62553c7 View commit details

   Browse the repository at this point in the history