Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only iterate panes one time when updating settings #10997

Merged
4 commits merged into from
Aug 23, 2021
Merged

Only iterate panes one time when updating settings #10997

4 commits merged into from
Aug 23, 2021

Commits on Aug 23, 2021

  1. Only iterate panes one time when updating settings 

    The original code for settings reload iterated the entire tree of panes
for every profile in the new settings, and constructed a
TerminalSettings object for every profile even if it later went unused.

This implementation:

1. Collects all new profiles keyed by guid
1.a. Adds the "defaults" profile to the map
2. Iterates every pane, just once, and updates its profile if it shows
   up in the list by GUID.

I've merged all of the per-tab code into a single loop.

Because of 1.a., this code can now update panes that are hosting the
"base" profile.
    @DHowett
    DHowett committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    fe9c458 View commit details
    Browse the repository at this point in the history

  2. PR feedback

    @DHowett
    DHowett committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    dc9cc19 View commit details
    Browse the repository at this point in the history

  3. PR feedback

    @DHowett
    DHowett committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    82aef2f View commit details
    Browse the repository at this point in the history

  4. PR feedbacc III: feedbacc harder

    @DHowett
    DHowett committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    3af12d2 View commit details
    Browse the repository at this point in the history