Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix directional movement during startup #11023

Merged
1 commit merged into from
Aug 24, 2021
Merged

Fix directional movement during startup #11023

1 commit merged into from
Aug 24, 2021

Conversation

Rosefield
Copy link
Contributor

@Rosefield Rosefield commented Aug 23, 2021 •
edited by DHowett
Loading

During startup we do not have real dimensions, so we have to guess what
our dimensions should be based off of the splits.

We'll augment the state of the pane search to also have a size in each
dimension that gets incrementally upgraded as we recurse through the
tree.

References #10978

@Rosefield
Copy link
Contributor Author

Seriously, on every branch the feature tests fail? Is there a problem with the CI and running from forks or something?

@DHowett
Copy link
Member

DHowett commented Aug 24, 2021

Seriously, on every branch the feature tests fail? Is there a problem with the CI and running from forks or something?

We recently moved to new build agents, and unfortunately some of our tests are timing-sensitive. I'll book some work for us to shore them up. Sorry about that 😄

@Rosefield
Copy link
Contributor Author

I apologize, rereading my comment my wording could have been better. I meant to express surprise that this kept happening, not any sense of anger.

@zadjii-msft
Copy link
Member

Don't worry, none taken. We submit PRs more than anyone else, so yea this has been a major pain 🙃

zadjii-msft
zadjii-msft approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for whipping this up so fast!

@zadjii-msft zadjii-msft added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal. labels Aug 24, 2021
DHowett
DHowett approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing, and I love it. Thanks for the comprehensive fixes lately!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 24, 2021
@ghost
Copy link

ghost commented Aug 24, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 2c3368f into microsoft:main Aug 24, 2021
@Rosefield Rosefield deleted the bug/move-focus-direction-commandline-not-working branch August 24, 2021 16:04
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rosefield @DHowett @zadjii-msft