Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first pane movement for MoveFocus/SwapPane. #11044

Merged
4 commits merged into from
Aug 26, 2021

Conversation

Rosefield
Copy link
Contributor

@Rosefield Rosefield commented Aug 26, 2021

This commit adds the ability to target the first pane in the tree,
always.

I wasn't able to find an existing issue for this, it is just a personal
feature for me. I won't be heartbroken if it does not get merged.

As motivation, I frequently have setups where the thing I am primarily
working on is a large pane on the left and everything else is in smaller
panes positioned elsewhere. I like to have one hotkey where I can go to
any pane and then make it the "primary" pane if I am changing what I am
working on or need to focus on another set of code/documentation/etc.

Validation Steps Performed

Confirmed that the move focus and swap pane variants both affect the
correct pane.

@DHowett
Copy link
Member

DHowett commented Aug 26, 2021

Oh my gosh, I finally understand! You might have just revolutionized my workflow, too!

Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frankly all the rest of the code other than this one localization thing is great. If the loc issue isn't actually an issue, then Dustin can feel free to dismiss me if this gests ✔️'s while I'm out

src/cascadia/TerminalSettingsModel/ActionArgs.cpp Outdated Show resolved Hide resolved
@ghost ghost added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 26, 2021
@ghost ghost removed the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Aug 26, 2021
@Rosefield
Copy link
Contributor Author

The diff is certainly smaller if you don't try to refactor anything :P

Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, and additionally for the loc changes/unchanges!

@DHowett
Copy link
Member

DHowett commented Aug 26, 2021

@msftbot merge this in 2 minutes

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 26, 2021
@ghost
Copy link

ghost commented Aug 26, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 26 Aug 2021 17:51:03 GMT, which is in 2 minutes

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 07dc060 into microsoft:main Aug 26, 2021
DHowett pushed a commit that referenced this pull request Aug 26, 2021
This commit adds the ability to target the first pane in the tree,
always.

I wasn't able to find an existing issue for this, it is just a personal
feature for me. I won't be heartbroken if it does not get merged.

As motivation, I frequently have setups where the thing I am primarily
working on is a large pane on the left and everything else is in smaller
panes positioned elsewhere. I like to have one hotkey where I can go to
any pane and then make it the "primary" pane if I am changing what I am
working on or need to focus on another set of code/documentation/etc.

## Validation Steps Performed
Confirmed that the move focus and swap pane variants both affect the
correct pane.

(cherry picked from commit 07dc060)
@Rosefield Rosefield deleted the feature/first-pane-movement branch August 26, 2021 18:06
@DHowett
Copy link
Member

DHowett commented Aug 26, 2021

Hey @Rosefield, I'm writing up the release notes right now and you've earned yourself an entire section. In addition to your github username, is there any particular name you'd like me to use to credit you? I know you have your first/last on your profile, but I didn't want to just pull them without asking 😄

@Rosefield
Copy link
Contributor Author

I think my name, Schuyler Rosefield, is fine to use. Thanks for asking!

@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Oct 20, 2021

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants