Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to interact with subtrees of panes #11153

Merged
28 commits merged into from
Sep 28, 2021

Commits on Sep 6, 2021

  1. Add the ability to interact with subtrees of panes

    - Add `parent` and `child` movement directions to move up and down the tree respectively
    - When a parent pane is selected it will have borders all around it in addition to any borders the children have.
    - Fix focus, swap, split, zoom, and move to all handle interacting with more than one pane.
    - This technically leaves control focus on the first control in the focused subtree because panes aren't proper controls themselves.
    Rosefield committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    04afd36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1a22a0b View commit details
    Browse the repository at this point in the history
  3. Remember which terminal was previously focused when we move focus to …

    …the parent. this allows us to maintain focus on the correct terminal and also go back down the correct path with the child navigation.
    Rosefield committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    59c1db3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0c900a7 View commit details
    Browse the repository at this point in the history
  5. Make sure the right borders get set when swapping panes, and then don…

    …t overwrite them if the two parents are related.
    Rosefield committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    8610cb8 View commit details
    Browse the repository at this point in the history
  6. typo

    Rosefield committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    d20ce76 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    200bee1 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    9cfee03 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Merge remote-tracking branch 'origin/main' into feature/gh10733-selec…

    …t-subtree-panes
    
     Conflicts:
    	src/cascadia/TerminalApp/Pane.cpp
    	src/cascadia/TerminalApp/TerminalTab.cpp
    Rosefield committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    259281e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Make more actions on parent panes distribute to their children

    - font size changing, closing, read-only, clear buffer, changing color scheme all updated for parent panes
    - Make the WalkTree function more ergonomic to use, so in the default case you don't have to return a bool
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    aba116b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8f144a View commit details
    Browse the repository at this point in the history
  3. Make sure the next in order movement skips any children of the parent…

    … pane when a parent is focused
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    1db7b75 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6a8c70c View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Configuration menu
    Copy the full SHA
    63ab706 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Fix focus if a parent was focused, and a child exit'd under it

    - Switch to keeping a path of panes instead of a direct pointer, and update
      that on close.
    - Make sure that we focus a terminal after close.
    - Also update the tab active pane information on close in case a child of
      the focused pane closed, since the GotFocus handler will rightfully ignore
      that the same pane is getting focused again (but still information about it
      changed).
    - Add TODO on previewing color schemes.
    Rosefield committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    53a7fa7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c01bb5e View commit details
    Browse the repository at this point in the history
  3. Dont remove the path on all movement because we might fail to move an…

    …d that would cause the correct focus to be lost.
    Rosefield committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    effa02b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    53de81f View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Always redraw when toggling shader effects so it doesnt look like it …

    …is broken on unfocused terminals.
    Rosefield committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    1d7c5de View commit details
    Browse the repository at this point in the history
  2. Be smarter and only clear when we are focusing something new so that …

    …we dont lose context when we swap panes.
    Rosefield committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    7dfef40 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ee4f13c View commit details
    Browse the repository at this point in the history
  4. Merge remote-tracking branch 'origin/main' into feature/gh10733-selec…

    …t-subtree-panes
    
     Conflicts:
    	src/cascadia/TerminalApp/Pane.cpp
    Rosefield committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    f18ba76 View commit details
    Browse the repository at this point in the history
  5. Always recreate the device when we change the shader effects because …

    …otherwise they hold onto buffer references that break resizing
    Rosefield committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    ed076ba View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2021

  1. Configuration menu
    Copy the full SHA
    396da17 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    52dfb41 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    fad6bda View commit details
    Browse the repository at this point in the history
  2. Fix tests that I broke.

    Rosefield committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    812ccc9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3f89139 View commit details
    Browse the repository at this point in the history