Reduce usage of Json::Value throughout Terminal.Settings.Model

.github/actions/spelling/expect/expect.txt

@@ -557,6 +557,7 @@ DECSTR
 DECSWL
 DECTCEM
 Dedupe
+deduplicate
 deduplicated
 DEFAPP
 DEFAULTBACKGROUND
@@ -784,6 +785,7 @@ FINDSTRINGEXACT
 FINDUP
 FIter
 FIXEDCONVERTED
+FIXEDFILEINFO
 Flg
 flyout
 fmodern
@@ -1992,6 +1994,7 @@ resx
 retval
 rfa
 rfc
+rfid
 rftp
 rgb
 rgba

README.md

@@ -289,6 +289,7 @@ If you would like to ask a question that you feel doesn't warrant an issue
 * You must [enable Developer Mode in the Windows Settings
   app](https://docs.microsoft.com/en-us/windows/uwp/get-started/enable-your-device-for-development)
   to locally install and run Windows Terminal
+* You must have [PowerShell 7 or later](https://github.com/PowerShell/PowerShell/releases/latest) installed
 * You must have the [Windows 10 1903
   SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk)
   installed

src/cascadia/LocalTests_SettingsModel/CommandTests.cpp

@@ -43,12 +43,6 @@ namespace SettingsModelLocalTests
         TEST_METHOD(TestLayerOnAutogeneratedName);
 
         TEST_METHOD(TestGenerateCommandline);
-
-        TEST_CLASS_SETUP(ClassSetup)
-        {
-            InitializeJsonReader();
-            return true;
-        }
     };
 
     void CommandTests::ManyCommandsSameAction()

src/cascadia/LocalTests_SettingsModel/JsonTestClass.h

@@ -7,44 +7,34 @@ Module Name:
 
 Abstract:
 - This class is a helper that can be used to quickly create tests that need to
-  read & parse json data. Test classes that need to read JSON should make sure
-  to derive from this class, and also make sure to call InitializeJsonReader()
-  in the TEST_CLASS_SETUP().
+  read & parse json data.
 
 Author(s):
     Mike Griese (migrie) August-2019
 --*/
 
+#pragma once
+
 class JsonTestClass
 {
 public:
-    void InitializeJsonReader()
-    {
-        _reader = std::unique_ptr<Json::CharReader>(Json::CharReaderBuilder::CharReaderBuilder().newCharReader());
-    };
-
-    void InitializeJsonWriter()
+    static Json::Value VerifyParseSucceeded(const std::string_view& content)
     {
-        _writer = std::unique_ptr<Json::StreamWriter>(Json::StreamWriterBuilder::StreamWriterBuilder().newStreamWriter());
-    }
+        static const std::unique_ptr<Json::CharReader> reader{ Json::CharReaderBuilder::CharReaderBuilder().newCharReader() };
 
-    Json::Value VerifyParseSucceeded(std::string content)
-    {
         Json::Value root;
         std::string errs;
-        const bool parseResult = _reader->parse(content.c_str(), content.c_str() + content.size(), &root, &errs);
+        const bool parseResult = reader->parse(content.data(), content.data() + content.size(), &root, &errs);
         VERIFY_IS_TRUE(parseResult, winrt::to_hstring(errs).c_str());
         return root;
     };
 
-    std::string toString(const Json::Value& json)
+    static std::string toString(const Json::Value& json)
     {
+        static const std::unique_ptr<Json::StreamWriter> writer{ Json::StreamWriterBuilder::StreamWriterBuilder().newStreamWriter() };
+
         std::stringstream s;
-        _writer->write(json, &s);
+        writer->write(json, &s);
         return s.str();
     }
-
-protected:
-    std::unique_ptr<Json::CharReader> _reader;
-    std::unique_ptr<Json::StreamWriter> _writer;
 };

src/cascadia/LocalTests_SettingsModel/KeyBindingsTests.cpp

@@ -59,12 +59,6 @@ namespace SettingsModelLocalTests
 
         TEST_METHOD(TestGetKeyBindingForAction);
         TEST_METHOD(KeybindingsWithoutVkey);
-
-        TEST_CLASS_SETUP(ClassSetup)
-        {
-            InitializeJsonReader();
-            return true;
-        }
     };
 
     void KeyBindingsTests::KeyChords()