Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attempt to make the monarch more thread safe. #11189

Merged
14 commits merged into from
Sep 21, 2021
Merged

Attempt to make the monarch more thread safe. #11189

14 commits merged into from
Sep 21, 2021

Commits on Sep 9, 2021

  1. Attempt to make the monarch more thread safe.

    @Rosefield
    Rosefield committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    4eedfcc View commit details
    Browse the repository at this point in the history

  2. spelling and formatting.

    @Rosefield
    Rosefield committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    825dfc3 View commit details
    Browse the repository at this point in the history

  3. Use _forEachPeasant correctly, and make the dead peasant use the erro… 

    …r code we expect a dead peasant to have.
    @Rosefield
    Rosefield committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    91f1845 View commit details
    Browse the repository at this point in the history

  4. Some code review

    @Rosefield
    Rosefield committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e386d6f View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Actually compiling the code is a good idea.

    @Rosefield
    Rosefield committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    f765728 View commit details
    Browse the repository at this point in the history

  2. Change a fail_fast to an assert

    @Rosefield
    Rosefield committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    5f632f4 View commit details
    Browse the repository at this point in the history

  3. More code review changes: be less trict about memory ordering

    @Rosefield
    Rosefield committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ee463aa View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Merge remote-tracking branch 'origin/main' into bug/make-monarch-more… 

    …-thread-safe

 Conflicts:
	src/cascadia/Remoting/Monarch.cpp
	src/cascadia/UnitTests_Remoting/RemotingTests.cpp
    @Rosefield
    Rosefield committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    3aeaeed View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Refactor _getMostRecentPeasantID so that we dont need to have a recur… 

    …sive_mutex. This is done by making _getPeasant not remove from _mruPeasants on failure, and _getMostRecentPeasantID handle its own cleanup.
    @Rosefield
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    2f0db9e View commit details
    Browse the repository at this point in the history

  2. make the spellchecker happy

    @Rosefield
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    e1c2f53 View commit details
    Browse the repository at this point in the history

  3. Explicitly unlock _mruPeasants when we are done with it to prevent a … 

    …deadlock from being introduced.
    @Rosefield
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    80646b3 View commit details
    Browse the repository at this point in the history

  4. Be more careful to ensure no deadlocks can occur. Annotate methods th… 

    …at take unique locks.
    @Rosefield
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    be2cdbe View commit details
    Browse the repository at this point in the history

  5. use an actually appropriate std method instead of something exotic li… 

    …ke stable_partition
    @Rosefield
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d95629b View commit details
    Browse the repository at this point in the history

  6. Use unordered_sets instead of vectors for erasing.

    @Rosefield
    Rosefield committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    8fd2b75 View commit details
    Browse the repository at this point in the history