Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind resetFontSize to numpad_0 #11243

Merged
1 commit merged into from
Sep 16, 2021
Merged

Bind resetFontSize to numpad_0 #11243

1 commit merged into from
Sep 16, 2021

Conversation

BenConstable9
Copy link
Contributor

@BenConstable9 BenConstable9 commented Sep 15, 2021 •
edited by lhecker
Loading

We already had resetFontSize bound to ctrl+0. As discussed in
#11239 it should be possible to do the same with ctrl+numpad_0.

PR Checklist

Validation Steps Performed

  • Resetting the font size with ctrl+numpad_0 works

@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. labels Sep 15, 2021
carlos-zamora
carlos-zamora approved these changes Sep 16, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carlos-zamora carlos-zamora mentioned this pull request Sep 16, 2021
Merged
@carlos-zamora carlos-zamora changed the title Add in numpad_0 Bind resetFontSize to numpad_0 by default Sep 16, 2021
@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Sep 16, 2021
@carlos-zamora carlos-zamora changed the title Bind resetFontSize to numpad_0 by default Bind resetFontSize to numpad_0 Sep 16, 2021
@lhecker lhecker added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 16, 2021
@ghost ghost requested a review from lhecker September 16, 2021 00:31
@ghost
Copy link

ghost commented Sep 16, 2021

Hello @lhecker!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 6 hours 41 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit fcb42b2 into microsoft:main Sep 16, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Oct 20, 2021
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

@zadjii-msft zadjii-msft Awaiting requested review from zadjii-msft

@miniksa miniksa Awaiting requested review from miniksa

@DHowett DHowett Awaiting requested review from DHowett

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

resetFontSize not working when using ctrl+numpad_zero
3 participants
@BenConstable9 @lhecker @carlos-zamora