Fix compatibility issues with profiles.schema.json #11360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest reviewing the two commits seperately. |
zadjii-msft
approved these changes
Sep 28, 2021
miniksa
approved these changes
Sep 29, 2021
|
@miniksa Actually I didn't check it with VS Code. Let me do that now, but I'm certain it'll work since it works with any of the online JSON schema testers out there. edit: Yep it works. |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues with profiles.schema.json:
$schemashould not end in a#$defsis the official reserved keyword for schema re-useSee: http://json-schema.org/draft/2020-12/json-schema-core.html
PR Checklist
Validation Steps Performed
The previous schema didn't pass https://jschon.dev/, the new schema does.