Fix the `wt` action in defterm windows #11646

zadjii-msft · 2021-10-28T21:16:17Z

This is a pretty obvious typo in retrospect. Never hit it before, because in all non-defterm windows, the _startupActions always has one action.

Closes DefTerm window will not accept command palette *commandline mode* commands #11463

DHowett · 2021-10-28T21:56:55Z

src/cascadia/TerminalApp/AppActionHandlers.cpp

@@ -556,7 +556,7 @@ namespace winrt::TerminalApp::implementation
            auto actions = winrt::single_threaded_vector<ActionAndArgs>(std::move(
                TerminalPage::ConvertExecuteCommandlineToActions(realArgs)));

-            if (_startupActions.Size() != 0)
+            if (actions.Size() != 0)


ghost · 2021-10-29T14:06:39Z

Hello @zadjii-msft!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.

This is a pretty obvious typo in retrospect. Never hit it before, because in all non-defterm windows, the `_startupActions` always has one action. * [x] Closes #11463 (cherry picked from commit b90f360)

ghost · 2021-12-14T20:44:06Z

🎉Windows Terminal Preview v1.12.3472.0 has been released which incorporates this pull request.:tada:

Handy links:

ghost · 2021-12-14T20:45:39Z

🎉Windows Terminal v1.11.3471.0 has been released which incorporates this pull request.:tada:

Handy links:

zadjii-msft added 2 commits October 28, 2021 16:11

oh you gotta be

1b4cd3d

great cool these weren't needed

a602374

ghost added Area-CmdPal Command Palette issues and features Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. labels Oct 28, 2021

DHowett reviewed Oct 28, 2021

View reviewed changes

DHowett approved these changes Oct 28, 2021

View reviewed changes

lhecker approved these changes Oct 29, 2021

View reviewed changes

mkmibrahim approved these changes Oct 29, 2021

View reviewed changes

zadjii-msft added the AutoMerge Marked for automatic merge by the bot when requirements are met label Oct 29, 2021

ghost merged commit b90f360 into main Oct 29, 2021

ghost deleted the dev/migrie/b/11463-defterm-wt-command branch October 29, 2021 14:09

ghost mentioned this pull request Dec 14, 2021

DefTerm window will not accept command palette *commandline mode* commands #11463

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix the `wt` action in defterm windows #11646

Fix the `wt` action in defterm windows #11646

zadjii-msft commented Oct 28, 2021

DHowett Oct 28, 2021

ghost commented Oct 29, 2021

ghost commented Dec 14, 2021

ghost commented Dec 14, 2021

Fix the wt action in defterm windows #11646

Fix the wt action in defterm windows #11646

Conversation

zadjii-msft commented Oct 28, 2021

DHowett Oct 28, 2021

Choose a reason for hiding this comment

ghost commented Oct 29, 2021

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

ghost commented Dec 14, 2021

ghost commented Dec 14, 2021

Fix the `wt` action in defterm windows #11646

Fix the `wt` action in defterm windows #11646

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (`@msftbot`) and give me an instruction to get started! Learn more here.